Warnings clean up

Author: cowtowncoder

src/test/java/com/fasterxml/jackson/databind/deser/AnySetterFieldWithCreator4639Test.java

@@ -15,15 +15,14 @@
 
 // [databind#4639] 2.18.1 : regression when using @JsonAnySetter outside of @JsonCreator
 public class AnySetterFieldWithCreator4639Test
-        extends DatabindTestUtil
+    extends DatabindTestUtil
 {
-
     public static class Bean {
-        private int b;
-        private int d;
+        int b;
+        int d;
 
         @JsonAnySetter
-        private Map<String, ?> any;
+        Map<String, ?> any;
 
         @JsonCreator
         public Bean(@JsonProperty("b") int b, @JsonProperty("d") int d) {

src/test/java/com/fasterxml/jackson/databind/deser/creators/SingleImmutableFieldCreatorTest.java

@@ -18,7 +18,7 @@ public class SingleImmutableFieldCreatorTest
     extends DatabindTestUtil
 {
     static class ImmutableId {
-        private final int id;
+        final int id;
 
         public ImmutableId(int id) { this.id = id; }
 
@@ -28,7 +28,7 @@ public int getId() {
     }
 
     static class ImmutableIdWithEmptyConstuctor {
-        private final int id;
+        final int id;
 
         public ImmutableIdWithEmptyConstuctor() { this(-1); }
 
@@ -40,7 +40,7 @@ public int getId() {
     }
 
     static class ImmutableIdWithJsonCreatorAnnotation {
-        private final int id;
+        final int id;
 
         @JsonCreator
         public ImmutableIdWithJsonCreatorAnnotation(int id) { this.id = id; }
@@ -51,7 +51,8 @@ public int getId() {
     }
 
     static class ImmutableIdWithJsonPropertyFieldAnnotation {
-        @JsonProperty("id") private final int id;
+        @JsonProperty("id")
+        final int id;
 
         public ImmutableIdWithJsonPropertyFieldAnnotation(int id) { this.id = id; }
 
@@ -61,7 +62,7 @@ public int getId() {
     }
 
     static class ImmutableIdWithJsonPropertyConstructorAnnotation {
-        private final int id;
+        final int id;
 
         public ImmutableIdWithJsonPropertyConstructorAnnotation(@JsonProperty("id") int id) { this.id = id; }
 

src/test/java/com/fasterxml/jackson/databind/ser/TestConfig.java

@@ -152,17 +152,16 @@ public void testProviderConfig() throws Exception
         DefaultSerializerProvider prov = (DefaultSerializerProvider) mapper.getSerializerProvider();
         assertEquals(0, prov.cachedSerializersCount());
         // and then should get one constructed for:
-        Map<String,Object> result = this.writeAndMap(mapper, new AnnoBean());
+        Map<String,Object> result = writeAndMap(mapper, new AnnoBean());
         assertEquals(2, result.size());
         assertEquals(Integer.valueOf(1), result.get("x"));
         assertEquals(Integer.valueOf(2), result.get("y"));
 
-        /* Note: it is 2 because we'll also get serializer for basic 'int', not
-         * just AnnoBean
-         */
-        /* 12-Jan-2010, tatus: Actually, probably more, if and when we typing
-         *   aspects are considered (depending on what is cached)
-         */
+        // Note: it is 2 because we'll also get serializer for basic 'int', not
+        // just AnnoBean
+
+        // 12-Jan-2010, tatus: Actually, probably more, if and when we typing
+        //    aspects are considered (depending on what is cached)
         int count = prov.cachedSerializersCount();
         if (count < 2) {
             fail("Should have at least 2 cached serializers, got "+count);

src/test/java/com/fasterxml/jackson/databind/testutil/failure/JacksonTestFailureExpectedInterceptor.java

@@ -1,12 +1,11 @@
 package com.fasterxml.jackson.databind.testutil.failure;
 
+import java.lang.reflect.Method;
+
 import org.junit.jupiter.api.extension.ExtensionContext;
 import org.junit.jupiter.api.extension.InvocationInterceptor;
 import org.junit.jupiter.api.extension.ReflectiveInvocationContext;
 
-import java.lang.reflect.Method;
-import java.util.List;
-
 /**
  * Custom {@link InvocationInterceptor} that intercepts test method invocation.
  * To pass the test ***only if*** test fails with an exception, and fail the test otherwise.
@@ -16,11 +15,11 @@
 public class JacksonTestFailureExpectedInterceptor
     implements InvocationInterceptor
 {
-
     @Override
     public void interceptTestMethod(Invocation<Void> invocation,
-                                    ReflectiveInvocationContext<Method> invocationContext, ExtensionContext extensionContext)
-            throws Throwable {
+            ReflectiveInvocationContext<Method> invocationContext, ExtensionContext extensionContext)
+        throws Throwable
+    {
         try {
             invocation.proceed();
         } catch (Throwable t) {
@@ -34,7 +33,7 @@ private void handleUnexpectePassingTest(ReflectiveInvocationContext<Method> invo
         // Collect information we need
         Object targetClass = invocationContext.getTargetClass();
         Object testMethod = invocationContext.getExecutable().getName();
-        List<Object> arguments = invocationContext.getArguments();
+        //List<Object> arguments = invocationContext.getArguments();
 
         // Create message
         String message = String.format("Test method %s.%s() passed, but should have failed", targetClass, testMethod);

src/test/java/com/fasterxml/jackson/databind/testutil/failure/JacksonTestShouldFailException.java

@@ -10,6 +10,8 @@
 public class JacksonTestShouldFailException
     extends RuntimeException
 {
+    private static final long serialVersionUID = 1L;
+
     public JacksonTestShouldFailException(String msg) {
         super(msg);
     }

src/test/java/com/fasterxml/jackson/databind/tofix/JacksonBuilderCreatorSubtype4742Test.java

@@ -19,9 +19,8 @@
 // [databind#4742] Deserialization with Builder, External type id,
 //                @JsonCreator not yet implemented
 public class JacksonBuilderCreatorSubtype4742Test
-        extends DatabindTestUtil
+    extends DatabindTestUtil
 {
-
     public static class Animals {
         @JsonProperty("animals")
         public List<Animal> animals;
@@ -64,11 +63,13 @@ public static class BuilderImpl extends Builder {
             private String kind;
             private AnimalProperties properties;
 
+            @Override
             public BuilderImpl kind(String kind) {
                 this.kind = kind;
                 return this;
             }
 
+            @Override
             public BuilderImpl properties(AnimalProperties properties) {
                 this.properties = properties;
                 return this;
@@ -107,12 +108,11 @@ public String toString() {
         }
     }
 
-    final ObjectMapper MAPPER = newJsonMapper();
+    private final ObjectMapper MAPPER = newJsonMapper();
 
     @JacksonTestFailureExpected
     @Test
-    public void testDeser()
-            throws Exception
+    public void testDeser() throws Exception
     {
         final Animals animals = MAPPER.readValue(
                 "{\n" +