Add failing tests for #2783

Author: cowtowncoder

src/main/java/com/fasterxml/jackson/databind/DeserializationContext.java

@@ -1198,7 +1198,7 @@ public Object handleUnexpectedToken(JavaType targetType, JsonParser p)
      * {@link JsonToken#VALUE_NUMBER_INT} or {@link JsonToken#VALUE_NUMBER_FLOAT}.
      *
      * @param targetType Type that was to be instantiated
-     * @param t Token encountered that does match expected
+     * @param t Token encountered that does not match expected
      * @param p Parser that points to the JSON value to decode
      *
      * @return Object that should be constructed, if any; has to be of type <code>instClass</code>

src/test/java/com/fasterxml/jackson/databind/ObjectReaderTest.java

@@ -26,6 +26,12 @@ static class POJO {
         public Map<String, Object> name;
     }
 
+    /*
+    /**********************************************************
+    /* Test methods, simple read/write with defaults
+    /**********************************************************
+     */
+
     public void testSimpleViaParser() throws Exception
     {
         final String JSON = "[1]";
@@ -89,6 +95,22 @@ public void testReaderForMapOf() throws Exception
         assertEquals(Collections.singletonMap("key", ABC.B), value);
     }
 
+    public void testNodeHandling() throws Exception
+    {
+        JsonNodeFactory nodes = new JsonNodeFactory(true);
+        ObjectReader r = MAPPER.reader().with(nodes);
+        // but also no further changes if attempting again
+        assertSame(r, r.with(nodes));
+        assertTrue(r.createArrayNode().isArray());
+        assertTrue(r.createObjectNode().isObject());
+    }
+
+    /*
+    /**********************************************************
+    /* Test methods, some alternative JSON settings
+    /**********************************************************
+     */
+
     public void testParserFeaturesComments() throws Exception
     {
         final String JSON = "[ /* foo */ 7 ]";
@@ -140,15 +162,11 @@ public void testParserFeaturesCtrlChars() throws Exception
         assertEquals(1, result.size());
     }
 
-    public void testNodeHandling() throws Exception
-    {
-        JsonNodeFactory nodes = new JsonNodeFactory(true);
-        ObjectReader r = MAPPER.reader().with(nodes);
-        // but also no further changes if attempting again
-        assertSame(r, r.with(nodes));
-        assertTrue(r.createArrayNode().isArray());
-        assertTrue(r.createObjectNode().isObject());
-    }
+    /*
+    /**********************************************************
+    /* Test methods, config setting verification
+    /**********************************************************
+     */
 
     public void testFeatureSettings() throws Exception
     {
@@ -268,6 +286,31 @@ public void testGetValueType() throws Exception
         assertEquals(MAPPER.constructType(String.class), r.getValueType());
     }
 
+    public void testParserConfigViaMapper() throws Exception
+    {
+        try (JsonParser p = MAPPER.reader()
+                .with(StreamReadFeature.STRICT_DUPLICATE_DETECTION)
+                .createParser("[ ]")) {
+            assertTrue(p.isEnabled(StreamReadFeature.STRICT_DUPLICATE_DETECTION));
+        }
+
+        try (JsonParser p = MAPPER.reader()
+                .with(JsonReadFeature.ALLOW_JAVA_COMMENTS)
+                .createParser("[ ]")) {
+            assertTrue(p.isEnabled(JsonReadFeature.ALLOW_JAVA_COMMENTS.mappedFeature()));
+        }
+    }
+
+    public void testGeneratorConfigViaMapper() throws Exception
+    {
+        StringWriter sw = new StringWriter();
+        try (JsonGenerator g = MAPPER.writer()
+                .with(StreamWriteFeature.IGNORE_UNKNOWN)
+                .createGenerator(sw)) {
+            assertTrue(g.isEnabled(StreamWriteFeature.IGNORE_UNKNOWN));
+        }
+    }
+
     /*
     /**********************************************************
     /* Test methods, JsonPointer