Skip to content

Commit b1b5fa5

Browse files
cowtowncodercowtowncoder
committed
Warnings (by latest Eclipse) removal (unneeded imports, private-access-via-synth-accessor)
1 parent 1014493 commit b1b5fa5

File tree

60 files changed

+82
-134
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+82
-134
lines changed

‎src/main/java/com/fasterxml/jackson/databind/AnnotationIntrospector.java

-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
import com.fasterxml.jackson.core.Version;
88
import com.fasterxml.jackson.core.Versioned;
99

10-
import com.fasterxml.jackson.databind.JsonDeserializer;
11-
import com.fasterxml.jackson.databind.JsonSerializer;
1210
import com.fasterxml.jackson.databind.annotation.JsonPOJOBuilder;
1311
import com.fasterxml.jackson.databind.annotation.JsonSerialize;
1412
import com.fasterxml.jackson.databind.cfg.MapperConfig;

‎src/main/java/com/fasterxml/jackson/databind/deser/BeanDeserializerModifier.java

-2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
import java.util.List;
44

55
import com.fasterxml.jackson.databind.*;
6-
import com.fasterxml.jackson.databind.deser.BeanDeserializer;
7-
import com.fasterxml.jackson.databind.deser.BeanDeserializerFactory;
86
import com.fasterxml.jackson.databind.introspect.BeanPropertyDefinition;
97
import com.fasterxml.jackson.databind.type.ArrayType;
108
import com.fasterxml.jackson.databind.type.CollectionLikeType;

‎src/main/java/com/fasterxml/jackson/databind/deser/impl/JavaUtilCollectionsDeserializers.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ private static class JavaUtilCollectionsConverter implements Converter<Object,Ob
121121

122122
private final int _kind;
123123

124-
private JavaUtilCollectionsConverter(int kind, JavaType inputType) {
124+
JavaUtilCollectionsConverter(int kind, JavaType inputType) {
125125
_inputType = inputType;
126126
_kind = kind;
127127
}

‎src/main/java/com/fasterxml/jackson/databind/deser/std/CollectionDeserializer.java

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import com.fasterxml.jackson.databind.annotation.JacksonStdImpl;
1212
import com.fasterxml.jackson.databind.deser.*;
1313
import com.fasterxml.jackson.databind.deser.impl.ReadableObjectId.Referring;
14-
import com.fasterxml.jackson.databind.deser.std.ContainerDeserializerBase;
1514
import com.fasterxml.jackson.databind.jsontype.TypeDeserializer;
1615
import com.fasterxml.jackson.databind.util.ClassUtil;
1716

‎src/test/java/com/fasterxml/jackson/databind/BaseMapTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
import com.fasterxml.jackson.core.*;
1111

12-
import com.fasterxml.jackson.databind.ObjectMapper;
1312
import com.fasterxml.jackson.databind.deser.std.StdScalarDeserializer;
1413
import com.fasterxml.jackson.databind.json.JsonMapper;
1514
import com.fasterxml.jackson.databind.ser.std.StdScalarSerializer;

‎src/test/java/com/fasterxml/jackson/databind/MapperViaParserTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import com.fasterxml.jackson.core.io.CharacterEscapes;
88
import com.fasterxml.jackson.core.io.SerializedString;
99
import com.fasterxml.jackson.core.json.JsonWriteFeature;
10-
import com.fasterxml.jackson.databind.ObjectMapper;
10+
1111
import com.fasterxml.jackson.databind.json.JsonMapper;
1212

1313
public class MapperViaParserTest extends BaseMapTest

‎src/test/java/com/fasterxml/jackson/databind/ObjectReaderTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -517,7 +517,7 @@ public boolean handleUnknownProperty(DeserializationContext ctxt, JsonParser p,
517517
}
518518

519519
private static class A{
520-
private String knownField;
520+
String knownField;
521521

522522
@JsonCreator
523523
private A(@JsonProperty("knownField") String knownField) {

‎src/test/java/com/fasterxml/jackson/databind/TestFormatSchema.java

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import com.fasterxml.jackson.core.io.IOContext;
99
import com.fasterxml.jackson.core.base.ParserBase;
1010
import com.fasterxml.jackson.core.base.GeneratorBase;
11-
import com.fasterxml.jackson.databind.ObjectMapper;
1211

1312
/**
1413
* Basic tests to ensure that {@link FormatSchema} instances are properly

‎src/test/java/com/fasterxml/jackson/databind/TestHandlerInstantiation.java

+2-6
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,9 @@
66
import com.fasterxml.jackson.annotation.*;
77
import com.fasterxml.jackson.annotation.JsonTypeInfo.As;
88
import com.fasterxml.jackson.annotation.JsonTypeInfo.Id;
9+
910
import com.fasterxml.jackson.core.*;
10-
import com.fasterxml.jackson.databind.DeserializationContext;
11-
import com.fasterxml.jackson.databind.JsonDeserializer;
12-
import com.fasterxml.jackson.databind.JsonSerializer;
13-
import com.fasterxml.jackson.databind.KeyDeserializer;
14-
import com.fasterxml.jackson.databind.ObjectMapper;
15-
import com.fasterxml.jackson.databind.SerializerProvider;
11+
1612
import com.fasterxml.jackson.databind.annotation.*;
1713
import com.fasterxml.jackson.databind.cfg.HandlerInstantiator;
1814
import com.fasterxml.jackson.databind.cfg.MapperConfig;

‎src/test/java/com/fasterxml/jackson/databind/TestRootName.java

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import com.fasterxml.jackson.annotation.*;
44

5-
import com.fasterxml.jackson.databind.ObjectMapper;
65
import com.fasterxml.jackson.databind.exc.MismatchedInputException;
76
import com.fasterxml.jackson.databind.json.JsonMapper;
87

‎src/test/java/com/fasterxml/jackson/databind/TestVersions.java

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import com.fasterxml.jackson.core.Version;
44
import com.fasterxml.jackson.core.Versioned;
55

6-
import com.fasterxml.jackson.databind.ObjectMapper;
76
import com.fasterxml.jackson.databind.introspect.JacksonAnnotationIntrospector;
87
import com.fasterxml.jackson.databind.cfg.PackageVersion;
98

‎src/test/java/com/fasterxml/jackson/databind/deser/AnySetterTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ static class Bean349
221221
public String type;
222222
public int x, y;
223223

224-
private Map<String, Object> props = new HashMap<>();
224+
Map<String, Object> props = new HashMap<>();
225225

226226
@JsonAnySetter
227227
public void addProperty(String key, Object value) {

‎src/test/java/com/fasterxml/jackson/databind/deser/TestObjectOrArrayDeserialization.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ public static class SomeObject {
1313
}
1414

1515
public static class ArrayOrObject {
16-
private final List<SomeObject> objects;
17-
private final SomeObject object;
16+
final List<SomeObject> objects;
17+
final SomeObject object;
1818

1919
@JsonCreator
2020
public ArrayOrObject(List<SomeObject> objects) {

‎src/test/java/com/fasterxml/jackson/databind/deser/builder/BuilderDeserializationTest2486.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ public class BuilderDeserializationTest2486
1212
{
1313
@JsonDeserialize(builder = MyPOJOWithArrayCreator.Builder.class)
1414
public static class MyPOJOWithArrayCreator {
15-
private final int index;
15+
final int index;
1616

17-
private MyPOJOWithArrayCreator(int i) {
17+
MyPOJOWithArrayCreator(int i) {
1818
index = i;
1919
}
2020

@@ -23,7 +23,7 @@ public int getIndex() {
2323
}
2424

2525
public static class Builder {
26-
private int index;
26+
int index;
2727

2828
public Builder() {
2929
// Default constructor
@@ -56,7 +56,7 @@ public MyPOJOWithArrayCreator build() {
5656
public static class MyPOJOWithPrimitiveCreator {
5757
private final int index;
5858

59-
private MyPOJOWithPrimitiveCreator(int i) {
59+
MyPOJOWithPrimitiveCreator(int i) {
6060
index = i;
6161
}
6262

@@ -65,7 +65,7 @@ public int getIndex() {
6565
}
6666

6767
public static class Builder {
68-
private int index;
68+
int index;
6969

7070
public Builder() {
7171
// Default constructor

‎src/test/java/com/fasterxml/jackson/databind/deser/builder/BuilderWithUnwrappedTest.java

+14-14
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ final static class Person {
3939
private final int age;
4040
private final boolean alive;
4141

42-
private Person(Builder builder) {
42+
Person(Builder builder) {
4343
id = builder.id;
4444
name = builder.name;
4545
age = builder.age;
@@ -64,10 +64,10 @@ boolean isAlive() {
6464

6565
@JsonPOJOBuilder(withPrefix = "set")
6666
final static class Builder {
67-
private final long id;
68-
private Name name;
69-
private int age;
70-
private boolean alive;
67+
final long id;
68+
Name name;
69+
int age;
70+
boolean alive;
7171

7272
Builder(@JsonProperty("person_id") long id) {
7373
this.id = id;
@@ -101,7 +101,7 @@ final static class Animal {
101101
private final int age;
102102
private final boolean alive;
103103

104-
private Animal(Builder builder) {
104+
Animal(Builder builder) {
105105
id = builder.id;
106106
name = builder.name;
107107
age = builder.age;
@@ -126,10 +126,10 @@ boolean isAlive() {
126126

127127
@JsonPOJOBuilder(withPrefix = "set")
128128
final static class Builder {
129-
private final long id;
130-
private Name name;
131-
private int age;
132-
private final boolean alive;
129+
final long id;
130+
Name name;
131+
int age;
132+
final boolean alive;
133133

134134
Builder(
135135
@JsonProperty("animal_id") long id,
@@ -161,7 +161,7 @@ final static class AnimalNoCreator {
161161
private final Name name;
162162
private final String age;
163163

164-
private AnimalNoCreator(Builder builder) {
164+
AnimalNoCreator(Builder builder) {
165165
id = builder.id;
166166
name = builder.name;
167167
age = builder.age;
@@ -181,9 +181,9 @@ String getAge() {
181181

182182
@JsonPOJOBuilder(withPrefix = "set")
183183
final static class Builder {
184-
private long id;
185-
private Name name;
186-
private String age;
184+
long id;
185+
Name name;
186+
String age;
187187

188188
Builder() { }
189189

‎src/test/java/com/fasterxml/jackson/databind/deser/creators/DelegatingExternalProperty1003Test.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,9 @@
77
public class DelegatingExternalProperty1003Test extends BaseMapTest
88
{
99
static class HeroBattle {
10+
final Hero hero;
1011

11-
private final Hero hero;
12-
13-
private HeroBattle(Hero hero) {
12+
HeroBattle(Hero hero) {
1413
if (hero == null) throw new Error();
1514
this.hero = hero;
1615
}

‎src/test/java/com/fasterxml/jackson/databind/deser/creators/ImplicitNameMatch792Test.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ static class ReadWriteBean
5454
{
5555
private int value;
5656

57-
private ReadWriteBean(@JsonProperty(value="value",
57+
ReadWriteBean(@JsonProperty(value="value",
5858
access=JsonProperty.Access.READ_WRITE) int v) {
5959
value = v;
6060
}

‎src/test/java/com/fasterxml/jackson/databind/deser/creators/TestCreators3.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ public static Product1853 from(String name){
115115
return new Product1853(false, "DELEG:"+name);
116116
}
117117

118-
private Product1853(boolean bogus, String name) {
118+
Product1853(boolean bogus, String name) {
119119
this.name = name;
120120
}
121121

‎src/test/java/com/fasterxml/jackson/databind/deser/jdk/DateDeserializationTZTest.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -28,21 +28,21 @@ public class DateDeserializationTZTest
2828

2929
static class Annot_TimeZone {
3030
@JsonFormat(timezone="GMT+4")
31-
private java.util.Date date;
31+
java.util.Date date;
3232
}
3333

3434
static class Annot_Pattern {
3535
@JsonFormat(pattern="'*'d MMM yyyy HH:mm:ss'*'")
36-
private java.util.Date pattern;
36+
java.util.Date pattern;
3737

3838
@JsonFormat(pattern="'*'d MMM yyyy HH:mm:ss'*'", locale="FR")
39-
private java.util.Date pattern_FR;
39+
java.util.Date pattern_FR;
4040

4141
@JsonFormat(pattern="'*'d MMM yyyy HH:mm:ss'*'", timezone="GMT+4")
42-
private java.util.Date pattern_GMT4;
42+
java.util.Date pattern_GMT4;
4343

4444
@JsonFormat(pattern="'*'d MMM yyyy HH:mm:ss'*'", locale="FR", timezone="GMT+4")
45-
private java.util.Date pattern_FR_GMT4;
45+
java.util.Date pattern_FR_GMT4;
4646
}
4747

4848
static class DateAsStringBean {

‎src/test/java/com/fasterxml/jackson/databind/deser/jdk/MapKeyDeserializationTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
public class MapKeyDeserializationTest extends BaseMapTest
1717
{
1818
static class FullName {
19-
private String _firstname, _lastname;
19+
String _firstname, _lastname;
2020

2121
private FullName(String firstname, String lastname) {
2222
_firstname = firstname;

‎src/test/java/com/fasterxml/jackson/databind/deser/jdk/TestEmptyArrayBlockingQueueDeser.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,6 @@ public void testEmptyBlockingQueue() throws Exception
2929
{
3030
String json = MAPPER.writeValueAsString(new RemoteEntity());
3131
Entity entity = MAPPER.readValue(json, Entity.class);
32-
assertEquals(0, entity.values.size());
32+
assertEquals(0, entity.getValues().size());
3333
}
3434
}

‎src/test/java/com/fasterxml/jackson/databind/deser/merge/NodeMergeTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
public class NodeMergeTest extends BaseMapTest
1010
{
11-
private final static ObjectMapper MAPPER = jsonMapperBuilder()
11+
final static ObjectMapper MAPPER = jsonMapperBuilder()
1212
// 26-Oct-2016, tatu: Make sure we'll report merge problems by default
1313
.disable(MapperFeature.IGNORE_MERGE_FOR_UNMERGEABLE)
1414
.build();

‎src/test/java/com/fasterxml/jackson/databind/exc/DeserExceptionTypeTest.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@
33
import java.io.*;
44

55
import com.fasterxml.jackson.core.*;
6+
67
import com.fasterxml.jackson.databind.*;
7-
import com.fasterxml.jackson.databind.exc.MismatchedInputException;
8-
import com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException;
98
import com.fasterxml.jackson.databind.testutil.BrokenStringReader;
109

1110
/**

‎src/test/java/com/fasterxml/jackson/databind/ext/TestCoreXMLTypes.java

-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import javax.xml.namespace.QName;
55

66
import com.fasterxml.jackson.databind.*;
7-
import com.fasterxml.jackson.databind.ext.CoreXMLDeserializers;
87
import com.fasterxml.jackson.databind.type.TypeFactory;
98

109
/**

‎src/test/java/com/fasterxml/jackson/databind/introspect/IsGetterRenaming2527Test.java

+2-4
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,13 @@
66
import com.fasterxml.jackson.annotation.JsonProperty;
77
import com.fasterxml.jackson.databind.*;
88
import com.fasterxml.jackson.databind.cfg.MapperConfig;
9-
import com.fasterxml.jackson.databind.introspect.AnnotatedField;
10-
import com.fasterxml.jackson.databind.introspect.JacksonAnnotationIntrospector;
119
import com.fasterxml.jackson.databind.util.BeanUtil;
1210

1311
// [databind#2527] Support Kotlin-style "is" properties
1412
public class IsGetterRenaming2527Test extends BaseMapTest
1513
{
1614
static class POJO2527 {
17-
private boolean isEnabled;
15+
boolean isEnabled;
1816

1917
protected POJO2527() { }
2018
public POJO2527(boolean b) {
@@ -38,7 +36,7 @@ public POJO2527PublicField(boolean b) {
3836
}
3937

4038
static class POJO2527Creator {
41-
private final boolean isEnabled;
39+
final boolean isEnabled;
4240

4341
public POJO2527Creator(@JsonProperty("enabled") boolean b) {
4442
isEnabled = b;

‎src/test/java/com/fasterxml/jackson/databind/introspect/TestAutoDetect.java

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import com.fasterxml.jackson.core.*;
99

1010
import com.fasterxml.jackson.databind.*;
11-
import com.fasterxml.jackson.databind.introspect.VisibilityChecker;
1211

1312
public class TestAutoDetect
1413
extends BaseMapTest

‎src/test/java/com/fasterxml/jackson/databind/introspect/TestBuilderMethods.java

-3
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
import java.util.Map;
44

55
import com.fasterxml.jackson.databind.*;
6-
import com.fasterxml.jackson.databind.introspect.BasicClassIntrospector;
7-
import com.fasterxml.jackson.databind.introspect.POJOPropertiesCollector;
8-
import com.fasterxml.jackson.databind.introspect.POJOPropertyBuilder;
96

107
public class TestBuilderMethods extends BaseMapTest
118
{

‎src/test/java/com/fasterxml/jackson/databind/introspect/TestJacksonAnnotationIntrospector.java

-2
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313
import com.fasterxml.jackson.databind.*;
1414
import com.fasterxml.jackson.databind.annotation.*;
1515
import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
16-
import com.fasterxml.jackson.databind.introspect.AnnotatedClass;
17-
import com.fasterxml.jackson.databind.introspect.JacksonAnnotationIntrospector;
1816
import com.fasterxml.jackson.databind.jsontype.TypeResolverBuilder;
1917
import com.fasterxml.jackson.databind.jsontype.impl.StdTypeResolverBuilder;
2018
import com.fasterxml.jackson.databind.type.TypeFactory;

‎src/test/java/com/fasterxml/jackson/databind/introspect/TestNamingStrategyCustom.java

-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
import com.fasterxml.jackson.databind.PropertyNamingStrategy;
1010
import com.fasterxml.jackson.databind.annotation.*;
1111
import com.fasterxml.jackson.databind.cfg.MapperConfig;
12-
import com.fasterxml.jackson.databind.introspect.AnnotatedField;
13-
import com.fasterxml.jackson.databind.introspect.AnnotatedMethod;
1412

1513
/**
1614
* Unit tests to verify functioning of {@link PropertyNamingStrategy}.

0 commit comments

Comments
 (0)