Fix #1788

Author: cowtowncoder

release-notes/VERSION

@@ -17,6 +17,7 @@ Project: jackson-databind
  (suggested by Luís C)
 #1771: Pass missing argument for string formatting in `ObjectMapper`
  (reported by Nils B)
+#1788: `StdDateFormat._parseAsISO8601()` does not parse "fractional" timezone correctly
 
 2.9.1 (07-Sep-2017)
 

src/main/java/com/fasterxml/jackson/databind/util/StdDateFormat.java

@@ -623,9 +623,9 @@ protected Date _parseAsISO8601(String dateStr, ParsePosition bogus)
                 int len = end-start;
                 if (len > 1) { // 0 -> none, 1 -> 'Z'
                     // NOTE: first char is sign; then 2 digits, then optional colon, optional 2 digits
-                    int offsetSecs = _parse2D(dateStr, start+1) * 3600;
+                    int offsetSecs = _parse2D(dateStr, start+1) * 3600; // hours
                     if (len >= 5) {
-                        offsetSecs += _parse2D(dateStr, end-2);
+                        offsetSecs += _parse2D(dateStr, end-2) * 60; // minutes
                     }
                     if (dateStr.charAt(start) == '-') {
                         offsetSecs *= -1000;

src/test/java/com/fasterxml/jackson/databind/deser/jdk/DateDeserializationTest.java

@@ -256,7 +256,23 @@ public void testISO8601PartialMilliseconds() throws Exception
         assertEquals(450, c.get(Calendar.MILLISECOND));
     }
 
-    // [Databind#1745]
+    // Also: minutes-part of offset need not be all zeroes: [databind#1788]
+    public void testISO8601FractionalTimezoneOffset() throws Exception
+    {
+        String inputStr = "1997-07-16T19:20:30.45+01:30";
+        java.util.Date inputDate = MAPPER.readValue(quote(inputStr), java.util.Date.class);
+        Calendar c = Calendar.getInstance(TimeZone.getTimeZone("GMT"));
+        c.setTime(inputDate);
+        assertEquals(1997, c.get(Calendar.YEAR));
+        assertEquals(Calendar.JULY, c.get(Calendar.MONTH));
+        assertEquals(16, c.get(Calendar.DAY_OF_MONTH));
+        assertEquals(19 - 2, c.get(Calendar.HOUR_OF_DAY));
+        assertEquals(50, c.get(Calendar.MINUTE));
+        assertEquals(30, c.get(Calendar.SECOND));
+        assertEquals(450, c.get(Calendar.MILLISECOND));
+    }
+
+    // [databind#1745]
     public void testISO8601FractSecondsLong() throws Exception
     {
         String inputStr;