Skip to content

Commit b02bf06

Browse files
committed
Fix #774 for 2.5.4
1 parent db612bb commit b02bf06

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

release-notes/VERSION

+2
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ Project: jackson-databind
88

99
#771: Annotation bundles ignored when added to Mixin
1010
(reported by Andrew D)
11+
#774: NPE from SqlDateSerializer as _useTimestamp is not checked for being null
12+
(reported by mrowkow@github)
1113
- Fix handling of Enums wrt JSON Schema, when 'toString()' used for serialization
1214

1315
2.5.3 (24-Apr-2015)

src/main/java/com/fasterxml/jackson/databind/ser/std/DateSerializer.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -42,18 +42,18 @@ protected long _timestamp(Date value) {
4242
}
4343

4444
@Override
45-
public void serialize(Date value, JsonGenerator jgen, SerializerProvider provider)
45+
public void serialize(Date value, JsonGenerator gen, SerializerProvider provider)
4646
throws IOException, JsonGenerationException
4747
{
4848
if (_asTimestamp(provider)) {
49-
jgen.writeNumber(_timestamp(value));
49+
gen.writeNumber(_timestamp(value));
5050
} else if (_customFormat != null) {
5151
// 21-Feb-2011, tatu: not optimal, but better than alternatives:
5252
synchronized (_customFormat) {
53-
jgen.writeString(_customFormat.format(value));
53+
gen.writeString(_customFormat.format(value));
5454
}
5555
} else {
56-
provider.defaultSerializeDateValue(value, jgen);
56+
provider.defaultSerializeDateValue(value, gen);
5757
}
5858
}
5959
}

src/main/java/com/fasterxml/jackson/databind/ser/std/SqlDateSerializer.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,13 @@ protected long _timestamp(java.sql.Date value) {
4242
}
4343

4444
@Override
45-
public void serialize(java.sql.Date value, JsonGenerator jgen, SerializerProvider provider)
45+
public void serialize(java.sql.Date value, JsonGenerator gen, SerializerProvider provider)
4646
throws IOException, JsonGenerationException
4747
{
48-
if (_useTimestamp) {
49-
jgen.writeNumber(_timestamp(value));
48+
if (_asTimestamp(provider)) {
49+
gen.writeNumber(_timestamp(value));
5050
} else {
51-
jgen.writeString(value.toString());
51+
gen.writeString(value.toString());
5252
}
5353
}
5454

0 commit comments

Comments
 (0)