Skip to content

Commit 638dcdb

Browse files
committed
Backport #496 fix
1 parent 9a11fb9 commit 638dcdb

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

src/main/java/com/fasterxml/jackson/databind/node/TextNode.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -177,9 +177,13 @@ public String asText(String defaultValue) {
177177
@Override
178178
public boolean asBoolean(boolean defaultValue) {
179179
if (_value != null) {
180-
if ("true".equals(_value.trim())) {
180+
String v = _value.trim();
181+
if ("true".equals(v)) {
181182
return true;
182183
}
184+
if ("false".equals(v)) {
185+
return false;
186+
}
183187
}
184188
return defaultValue;
185189
}

src/test/java/com/fasterxml/jackson/databind/node/TestJsonNode.java

+5
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,11 @@ public void testText()
3131

3232
assertEquals("foobar", n.asText("barf"));
3333
assertEquals("", empty.asText("xyz"));
34+
35+
assertTrue(TextNode.valueOf("true").asBoolean(true));
36+
assertTrue(TextNode.valueOf("true").asBoolean(false));
37+
assertFalse(TextNode.valueOf("false").asBoolean(true));
38+
assertFalse(TextNode.valueOf("false").asBoolean(false));
3439
}
3540

3641
public void testBoolean()

0 commit comments

Comments
 (0)