Fix #935

Author: cowtowncoder

release-notes/VERSION

@@ -5,7 +5,8 @@ Project: jackson-databind
 
 2.8.7 (not yet released)
 
-#1317: '@JsonIgnore' annotation not working with creator properties, serialization
+#935: `@JsonProperty(access = Access.READ_ONLY)` - unexpected behaviour
+#1317: '@JsonIgnore' annotation not working with creator properties, serializatio
 
 2.8.6 (12-Jan-2017)
 

src/main/java/com/fasterxml/jackson/databind/introspect/POJOPropertiesCollector.java

@@ -4,6 +4,7 @@
 import java.util.*;
 
 import com.fasterxml.jackson.annotation.JsonAnySetter;
+import com.fasterxml.jackson.annotation.JsonProperty.Access;
 import com.fasterxml.jackson.databind.*;
 import com.fasterxml.jackson.databind.cfg.HandlerInstantiator;
 import com.fasterxml.jackson.databind.cfg.MapperConfig;
@@ -727,10 +728,14 @@ protected void _removeUnwantedAccessor(Map<String, POJOPropertyBuilder> props)
 
         while (it.hasNext()) {
             POJOPropertyBuilder prop = it.next();
-            prop.removeNonVisible(inferMutators);
+            // 26-Jan-2017, tatu: [databind#935]: need to denote removal of
+            Access acc = prop.removeNonVisible(inferMutators);
+            if (!_forSerialization && (acc == Access.READ_ONLY)) {
+                _collectIgnorals(prop.getName());
+            }
         }
     }
-        
+
     /**
      * Helper method called to add explicitly ignored properties to a list
      * of known ignored properties; this helps in proper reporting of

src/main/java/com/fasterxml/jackson/databind/introspect/POJOPropertyBuilder.java

@@ -641,7 +641,7 @@ public void removeIgnored()
      * @param inferMutators Whether mutators can be "pulled in" by visible
      *    accessors or not. 
      */
-    public void removeNonVisible(boolean inferMutators)
+    public JsonProperty.Access removeNonVisible(boolean inferMutators)
     {
         /* 07-Jun-2015, tatu: With 2.6, we will allow optional definition
          *  of explicit access type for property; if not "AUTO", it will
@@ -680,6 +680,7 @@ public void removeNonVisible(boolean inferMutators)
                 _setters = _removeNonVisible(_setters);
             }
         }
+        return acc;
     }
 
     /**

src/test/java/com/fasterxml/jackson/failing/ReadWriteOnlyProp935Test.java renamed to src/test/java/com/fasterxml/jackson/databind/deser/ReadOrWriteOnlyTest.java

@@ -1,9 +1,9 @@
-package com.fasterxml.jackson.failing;
+package com.fasterxml.jackson.databind.deser;
 
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.fasterxml.jackson.databind.*;
 
-public class ReadWriteOnlyProp935Test extends BaseMapTest
+public class ReadOrWriteOnlyTest extends BaseMapTest
 {
     // for [databind#935], verify read/write-only cases
     static class ReadXWriteY {
@@ -56,7 +56,7 @@ public void setLastName(String n) {
      */
 
     private final ObjectMapper MAPPER = new ObjectMapper();
-    
+
     // [databind#935]
     public void testReadOnlyAndWriteOnly() throws Exception
     {
@@ -69,7 +69,7 @@ public void testReadOnlyAndWriteOnly() throws Exception
         assertEquals(6, result.y);
     }
 
-    public void testReadOnl935() throws Exception
+    public void testReadOnly935() throws Exception
     {
         String json = MAPPER.writeValueAsString(new Pojo935());
         Pojo935 result = MAPPER.readValue(json, Pojo935.class);