Add a (now) passing test for #1637; fixed via jackson-core issue 330 (and patch thereof)

Author: cowtowncoder

release-notes/CREDITS

@@ -664,3 +664,8 @@ Patrick Gunia (pgunia@github)
 Carsten Wickner (CarstenWickner@github)
   * Contributed #1522: Global `@JsonInclude(Include.NON_NULL)` for all properties with a specific type
    (2.9.0)
+
+Chris Plummer (strmer15@github)
+  * Reported #1637: `ObjectReader.at()` with `JsonPointer` stops after first collection
+   (2.9.0)
+

release-notes/VERSION

@@ -87,6 +87,8 @@ Project: jackson-databind
  (requested by Jared J)
 #1616: Extraneous type id mapping added for base type itself
 #1619: By-pass annotation introspection for array types
+#1637: `ObjectReader.at()` with `JsonPointer` stops after first collection
+ (reported by Chris P)
 
 2.8.9 (not yet released)
 

src/test/java/com/fasterxml/jackson/databind/ObjectReaderTest.java

@@ -4,6 +4,7 @@
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
+import java.util.Set;
 
 import com.fasterxml.jackson.core.*;
 
@@ -65,73 +66,6 @@ public void testParserFeatures() throws Exception
             verifyException(e, "foo");
         }
     }
-    
-    public void testNoPointerLoading() throws Exception {
-        final String source = "{\"foo\":{\"bar\":{\"caller\":{\"name\":{\"value\":1234}}}}}";
-
-        JsonNode tree = MAPPER.readTree(source);
-        JsonNode node = tree.at("/foo/bar/caller");
-        POJO pojo = MAPPER.treeToValue(node, POJO.class);
-        assertTrue(pojo.name.containsKey("value"));
-        assertEquals(1234, pojo.name.get("value"));
-    }
-
-    public void testPointerLoading() throws Exception {
-        final String source = "{\"foo\":{\"bar\":{\"caller\":{\"name\":{\"value\":1234}}}}}";
-
-        ObjectReader reader = MAPPER.readerFor(POJO.class).at("/foo/bar/caller");
-
-        POJO pojo = reader.readValue(source);
-        assertTrue(pojo.name.containsKey("value"));
-        assertEquals(1234, pojo.name.get("value"));
-    }
-
-    public void testPointerLoadingAsJsonNode() throws Exception {
-        final String source = "{\"foo\":{\"bar\":{\"caller\":{\"name\":{\"value\":1234}}}}}";
-
-        ObjectReader reader = MAPPER.readerFor(POJO.class).at(JsonPointer.compile("/foo/bar/caller"));
-
-        JsonNode node = reader.readTree(source);
-        assertTrue(node.has("name"));
-        assertEquals("{\"value\":1234}", node.get("name").toString());
-    }
-
-    public void testPointerLoadingMappingIteratorOne() throws Exception {
-        final String source = "{\"foo\":{\"bar\":{\"caller\":{\"name\":{\"value\":1234}}}}}";
-
-        ObjectReader reader = MAPPER.readerFor(POJO.class).at("/foo/bar/caller");
-
-        MappingIterator<POJO> itr = reader.readValues(source);
-
-        POJO pojo = itr.next();
-
-        assertTrue(pojo.name.containsKey("value"));
-        assertEquals(1234, pojo.name.get("value"));
-        assertFalse(itr.hasNext());
-        itr.close();
-    }
-    
-    public void testPointerLoadingMappingIteratorMany() throws Exception {
-        final String source = "{\"foo\":{\"bar\":{\"caller\":[{\"name\":{\"value\":1234}}, {\"name\":{\"value\":5678}}]}}}";
-
-        ObjectReader reader = MAPPER.readerFor(POJO.class).at("/foo/bar/caller");
-
-        MappingIterator<POJO> itr = reader.readValues(source);
-
-        POJO pojo = itr.next();
-
-        assertTrue(pojo.name.containsKey("value"));
-        assertEquals(1234, pojo.name.get("value"));
-        assertTrue(itr.hasNext());
-        
-        pojo = itr.next();
-
-        assertNotNull(pojo.name);
-        assertTrue(pojo.name.containsKey("value"));
-        assertEquals(5678, pojo.name.get("value"));
-        assertFalse(itr.hasNext());
-        itr.close();
-    }
 
     public void testNodeHandling() throws Exception
     {
@@ -217,6 +151,108 @@ public void testNoPrefetch() throws Exception
         assertEquals(Integer.valueOf(123), n);
     }
 
+    /*
+    /**********************************************************
+    /* Test methods, JsonPointer
+    /**********************************************************
+     */
+
+    public void testNoPointerLoading() throws Exception {
+        final String source = "{\"foo\":{\"bar\":{\"caller\":{\"name\":{\"value\":1234}}}}}";
+
+        JsonNode tree = MAPPER.readTree(source);
+        JsonNode node = tree.at("/foo/bar/caller");
+        POJO pojo = MAPPER.treeToValue(node, POJO.class);
+        assertTrue(pojo.name.containsKey("value"));
+        assertEquals(1234, pojo.name.get("value"));
+    }
+
+    public void testPointerLoading() throws Exception {
+        final String source = "{\"foo\":{\"bar\":{\"caller\":{\"name\":{\"value\":1234}}}}}";
+
+        ObjectReader reader = MAPPER.readerFor(POJO.class).at("/foo/bar/caller");
+
+        POJO pojo = reader.readValue(source);
+        assertTrue(pojo.name.containsKey("value"));
+        assertEquals(1234, pojo.name.get("value"));
+    }
+
+    public void testPointerLoadingAsJsonNode() throws Exception {
+        final String source = "{\"foo\":{\"bar\":{\"caller\":{\"name\":{\"value\":1234}}}}}";
+
+        ObjectReader reader = MAPPER.readerFor(POJO.class).at(JsonPointer.compile("/foo/bar/caller"));
+
+        JsonNode node = reader.readTree(source);
+        assertTrue(node.has("name"));
+        assertEquals("{\"value\":1234}", node.get("name").toString());
+    }
+
+    public void testPointerLoadingMappingIteratorOne() throws Exception {
+        final String source = "{\"foo\":{\"bar\":{\"caller\":{\"name\":{\"value\":1234}}}}}";
+
+        ObjectReader reader = MAPPER.readerFor(POJO.class).at("/foo/bar/caller");
+
+        MappingIterator<POJO> itr = reader.readValues(source);
+
+        POJO pojo = itr.next();
+
+        assertTrue(pojo.name.containsKey("value"));
+        assertEquals(1234, pojo.name.get("value"));
+        assertFalse(itr.hasNext());
+        itr.close();
+    }
+    
+    public void testPointerLoadingMappingIteratorMany() throws Exception {
+        final String source = "{\"foo\":{\"bar\":{\"caller\":[{\"name\":{\"value\":1234}}, {\"name\":{\"value\":5678}}]}}}";
+
+        ObjectReader reader = MAPPER.readerFor(POJO.class).at("/foo/bar/caller");
+
+        MappingIterator<POJO> itr = reader.readValues(source);
+
+        POJO pojo = itr.next();
+
+        assertTrue(pojo.name.containsKey("value"));
+        assertEquals(1234, pojo.name.get("value"));
+        assertTrue(itr.hasNext());
+        
+        pojo = itr.next();
+
+        assertNotNull(pojo.name);
+        assertTrue(pojo.name.containsKey("value"));
+        assertEquals(5678, pojo.name.get("value"));
+        assertFalse(itr.hasNext());
+        itr.close();
+    }
+
+    // [databind#1637]
+    public void testPointerWithArrays() throws Exception
+    {
+        final String json = aposToQuotes("{\n'wrapper1': {\n" +
+                "  'set1': ['one', 'two', 'three'],\n" +
+                "  'set2': ['four', 'five', 'six']\n" +
+                "},\n" +
+                "'wrapper2': {\n" +
+                "  'set1': ['one', 'two', 'three'],\n" +
+                "  'set2': ['four', 'five', 'six']\n" +
+                "}\n}");
+
+        final Pojo1637 testObject = MAPPER.readerFor(Pojo1637.class)
+                .at("/wrapper1")
+                .readValue(json);
+        assertNotNull(testObject);
+
+        assertNotNull(testObject.set1);
+        assertTrue(!testObject.set1.isEmpty());
+
+        assertNotNull(testObject.set2);
+        assertTrue(!testObject.set2.isEmpty());
+    }
+
+    public static class Pojo1637 {
+        public Set<String> set1;
+        public Set<String> set2;
+    }    
+
     /*
     /**********************************************************
     /* Test methods, ObjectCodec