test cleanup

Author: cowtowncoder

src/test/java/com/fasterxml/jackson/databind/struct/ScalarCoercionTest.java

@@ -1,9 +1,13 @@
 package com.fasterxml.jackson.databind.struct;
 
+import java.io.ByteArrayInputStream;
 import java.io.IOException;
+import java.io.StringReader;
 import java.math.BigDecimal;
 import java.math.BigInteger;
 
+import com.fasterxml.jackson.core.JsonParser;
+import com.fasterxml.jackson.core.JsonToken;
 import com.fasterxml.jackson.databind.*;
 import com.fasterxml.jackson.databind.exc.MismatchedInputException;
 
@@ -138,23 +142,23 @@ public void testStringCoercionOk() throws Exception
 
     public void testStringCoercionFail() throws Exception
     {
-        _verifyCoerceFail(quote("true"), Boolean.TYPE);
-        _verifyCoerceFail(quote("true"), Boolean.class);
-        _verifyCoerceFail(quote("123"), Byte.TYPE);
-        _verifyCoerceFail(quote("123"), Byte.class);
-        _verifyCoerceFail(quote("123"), Short.TYPE);
-        _verifyCoerceFail(quote("123"), Short.class);
-        _verifyCoerceFail(quote("123"), Integer.TYPE);
-        _verifyCoerceFail(quote("123"), Integer.class);
-        _verifyCoerceFail(quote("123"), Long.TYPE);
-        _verifyCoerceFail(quote("123"), Long.class);
-        _verifyCoerceFail(quote("123.5"), Float.TYPE);
-        _verifyCoerceFail(quote("123.5"), Float.class);
-        _verifyCoerceFail(quote("123.5"), Double.TYPE);
-        _verifyCoerceFail(quote("123.5"), Double.class);
-
-        _verifyCoerceFail(quote("123"), BigInteger.class);
-        _verifyCoerceFail(quote("123.0"), BigDecimal.class);
+        _verifyRootStringCoerceFail("true", Boolean.TYPE);
+        _verifyRootStringCoerceFail("true", Boolean.class);
+        _verifyRootStringCoerceFail("123", Byte.TYPE);
+        _verifyRootStringCoerceFail("123", Byte.class);
+        _verifyRootStringCoerceFail("123", Short.TYPE);
+        _verifyRootStringCoerceFail("123", Short.class);
+        _verifyRootStringCoerceFail("123", Integer.TYPE);
+        _verifyRootStringCoerceFail("123", Integer.class);
+        _verifyRootStringCoerceFail("123", Long.TYPE);
+        _verifyRootStringCoerceFail("123", Long.class);
+        _verifyRootStringCoerceFail("123.5", Float.TYPE);
+        _verifyRootStringCoerceFail("123.5", Float.class);
+        _verifyRootStringCoerceFail("123.5", Double.TYPE);
+        _verifyRootStringCoerceFail("123.5", Double.class);
+
+        _verifyRootStringCoerceFail("123", BigInteger.class);
+        _verifyRootStringCoerceFail("123.0", BigDecimal.class);
     }
 
     public void testMiscCoercionFail() throws Exception
@@ -192,4 +196,38 @@ private void _verifyCoerceFail(String input, Class<?> type) throws IOException
             verifyException(e, "enable `MapperFeature.ALLOW_COERCION_OF_SCALARS` to allow");
         }
     }
+
+    private void _verifyRootStringCoerceFail(String unquotedValue, Class<?> type) throws IOException
+    {
+        // Test failure for root value: for both byte- and char-backed sources:
+
+        final String input = quote(unquotedValue);
+        try (JsonParser p = NOT_COERCING_MAPPER.getFactory().createParser(new StringReader(input))) {
+            _verifyStringCoerceFail(p, unquotedValue, type);
+        }
+        final byte[] inputBytes = utf8Bytes(input);
+        try (JsonParser p = NOT_COERCING_MAPPER.getFactory().createParser(new ByteArrayInputStream(inputBytes))) {
+            _verifyStringCoerceFail(p, unquotedValue, type);
+        }
+    }
+
+    private void _verifyStringCoerceFail(JsonParser p,
+            String unquotedValue, Class<?> type) throws IOException
+    {
+        try {
+            NOT_COERCING_MAPPER.readerFor(type)
+                .readValue(p);
+            fail("Should not have allowed coercion");
+        } catch (MismatchedInputException e) {
+            verifyException(e, "Cannot coerce ");
+            verifyException(e, " for type `");
+            verifyException(e, "enable `MapperFeature.ALLOW_COERCION_OF_SCALARS` to allow");
+
+            assertNotNull(e.getProcessor());
+            assertSame(p, e.getProcessor());
+
+            assertToken(JsonToken.VALUE_STRING, p.currentToken());
+            assertEquals(unquotedValue, p.getText());
+        }
+    }
 }