Skip to content

Commit 35bd198

Browse files
committed
Minor refactoring for #4217: move DatabindTestUtil under .../testutil
1 parent 790c487 commit 35bd198

File tree

6 files changed

+33
-23
lines changed

6 files changed

+33
-23
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
1-
package com.fasterxml.jackson.databind;
1+
package com.fasterxml.jackson.databind.testutil;
22

3-
import com.fasterxml.jackson.databind.json.JsonMapper;
43
import java.io.IOException;
4+
import java.nio.charset.StandardCharsets;
55
import java.util.LinkedHashMap;
66
import java.util.Map;
77

8+
import com.fasterxml.jackson.databind.*;
9+
import com.fasterxml.jackson.databind.json.JsonMapper;
10+
811
/**
912
* Class containing test utility methods.
1013
* The methods are migrated from {@link BaseMapTest} and {@link BaseTest},
@@ -14,6 +17,19 @@
1417
*/
1518
public class DatabindTestUtil
1619
{
20+
/*
21+
/**********************************************************
22+
/* Mapper construction helpers
23+
/**********************************************************
24+
*/
25+
26+
public static ObjectMapper newJsonMapper() {
27+
return new JsonMapper();
28+
}
29+
30+
public static JsonMapper.Builder jsonMapperBuilder() {
31+
return JsonMapper.builder();
32+
}
1733

1834
/*
1935
/**********************************************************
@@ -31,25 +47,19 @@ public static Map<String,Object> writeAndMap(ObjectMapper m, Object value)
3147

3248
/*
3349
/**********************************************************
34-
/* Construction
50+
/* Encoding or String representations
3551
/**********************************************************
3652
*/
3753

38-
public static ObjectMapper newJsonMapper() {
39-
return new JsonMapper();
54+
public static String a2q(String json) {
55+
return json.replace("'", "\"");
4056
}
4157

42-
public static JsonMapper.Builder jsonMapperBuilder() {
43-
return JsonMapper.builder();
58+
public static String q(String str) {
59+
return '"'+str+'"';
4460
}
4561

46-
/*
47-
/**********************************************************
48-
/* Encoding or String representations
49-
/**********************************************************
50-
*/
51-
52-
public static String a2q(String json) {
53-
return json.replace("'", "\"");
62+
public static byte[] utf8Bytes(String str) {
63+
return str.getBytes(StandardCharsets.UTF_8);
5464
}
5565
}

src/test/java/com/fasterxml/jackson/databind/views/DefaultViewTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.fasterxml.jackson.databind.views;
22

3-
import static com.fasterxml.jackson.databind.DatabindTestUtil.a2q;
3+
import static com.fasterxml.jackson.databind.testutil.DatabindTestUtil.a2q;
44
import static org.junit.Assert.assertEquals;
55
import java.io.IOException;
66

src/test/java/com/fasterxml/jackson/databind/views/TestViewDeserialization.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package com.fasterxml.jackson.databind.views;
22

3-
import static com.fasterxml.jackson.databind.DatabindTestUtil.a2q;
4-
import static com.fasterxml.jackson.databind.DatabindTestUtil.jsonMapperBuilder;
3+
import static com.fasterxml.jackson.databind.testutil.DatabindTestUtil.a2q;
4+
import static com.fasterxml.jackson.databind.testutil.DatabindTestUtil.jsonMapperBuilder;
55
import static org.junit.Assert.assertEquals;
66
import static org.junit.Assert.assertNull;
77
import com.fasterxml.jackson.annotation.JsonCreator;

src/test/java/com/fasterxml/jackson/databind/views/TestViewSerialization.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package com.fasterxml.jackson.databind.views;
22

3-
import static com.fasterxml.jackson.databind.DatabindTestUtil.jsonMapperBuilder;
4-
import static com.fasterxml.jackson.databind.DatabindTestUtil.newJsonMapper;
5-
import static com.fasterxml.jackson.databind.DatabindTestUtil.writeAndMap;
3+
import static com.fasterxml.jackson.databind.testutil.DatabindTestUtil.jsonMapperBuilder;
4+
import static com.fasterxml.jackson.databind.testutil.DatabindTestUtil.newJsonMapper;
5+
import static com.fasterxml.jackson.databind.testutil.DatabindTestUtil.writeAndMap;
66
import static org.junit.Assert.assertEquals;
77
import static org.junit.Assert.assertNull;
88
import java.io.*;

src/test/java/com/fasterxml/jackson/databind/views/TestViewsSerialization2.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.fasterxml.jackson.databind.views;
22

3-
import static com.fasterxml.jackson.databind.DatabindTestUtil.jsonMapperBuilder;
3+
import static com.fasterxml.jackson.databind.testutil.DatabindTestUtil.jsonMapperBuilder;
44
import static org.junit.Assert.assertEquals;
55
import static org.junit.Assert.assertTrue;
66
import java.io.*;

src/test/java/com/fasterxml/jackson/databind/views/ViewsWithCreatorTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.fasterxml.jackson.databind.views;
22

3-
import static com.fasterxml.jackson.databind.DatabindTestUtil.newJsonMapper;
3+
import static com.fasterxml.jackson.databind.testutil.DatabindTestUtil.newJsonMapper;
44
import static org.junit.Assert.assertEquals;
55
import com.fasterxml.jackson.annotation.*;
66

0 commit comments

Comments
 (0)