Skip to content

Commit 19ba372

Browse files
committed
minor streamlining
1 parent f54f0f1 commit 19ba372

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

src/main/java/com/fasterxml/jackson/databind/deser/BeanDeserializer.java

+12-9
Original file line numberDiff line numberDiff line change
@@ -549,7 +549,7 @@ protected Object deserializeWithUnwrapped(JsonParser p, DeserializationContext c
549549
}
550550
continue;
551551
}
552-
// ignorable things should be ignored
552+
// Things marked as ignorable should not be passed to any setter
553553
if (_ignorableProps != null && _ignorableProps.contains(propName)) {
554554
handleIgnoredProperty(p, ctxt, bean, propName);
555555
continue;
@@ -672,10 +672,7 @@ protected Object deserializeUsingPropertyBasedWithUnwrapped(JsonParser p, Deseri
672672
buffer.bufferProperty(prop, _deserializeWithErrorWrapping(p, ctxt, prop));
673673
continue;
674674
}
675-
676-
/* As per [JACKSON-313], things marked as ignorable should not be
677-
* passed to any setter
678-
*/
675+
// Things marked as ignorable should not be passed to any setter
679676
if (_ignorableProps != null && _ignorableProps.contains(propName)) {
680677
handleIgnoredProperty(p, ctxt, handledType(), propName);
681678
continue;
@@ -839,9 +836,7 @@ protected Object deserializeUsingPropertyBasedWithExternalTypeId(JsonParser p, D
839836
if (ext.handlePropertyValue(p, ctxt, propName, null)) {
840837
continue;
841838
}
842-
/* As per [JACKSON-313], things marked as ignorable should not be
843-
* passed to any setter
844-
*/
839+
// Things marked as ignorable should not be passed to any setter
845840
if (_ignorableProps != null && _ignorableProps.contains(propName)) {
846841
handleIgnoredProperty(p, ctxt, handledType(), propName);
847842
continue;
@@ -867,6 +862,14 @@ protected Object deserializeUsingPropertyBasedWithExternalTypeId(JsonParser p, D
867862
protected Object deserializeUsingDelegateWithExternalTypeId(JsonParser p, DeserializationContext ctxt)
868863
throws IOException
869864
{
870-
throw ctxt.mappingException("Combination of External Type Id, Delegating Creator not yet supported");
865+
// 24-Nov-2015, tatu: Something along these lines would normally work, in absence
866+
// of external type id:
867+
/*
868+
Object delegate = _delegateDeserializer.deserialize(p, ctxt);
869+
return _valueInstantiator.createUsingDelegate(ctxt, delegate);
870+
*/
871+
872+
throw ctxt.instantiationException(handledType(),
873+
"Combination of External Type Id, Delegating Creator not yet supported");
871874
}
872875
}

0 commit comments

Comments
 (0)