@@ -549,7 +549,7 @@ protected Object deserializeWithUnwrapped(JsonParser p, DeserializationContext c
549
549
}
550
550
continue ;
551
551
}
552
- // ignorable things should be ignored
552
+ // Things marked as ignorable should not be passed to any setter
553
553
if (_ignorableProps != null && _ignorableProps .contains (propName )) {
554
554
handleIgnoredProperty (p , ctxt , bean , propName );
555
555
continue ;
@@ -672,10 +672,7 @@ protected Object deserializeUsingPropertyBasedWithUnwrapped(JsonParser p, Deseri
672
672
buffer .bufferProperty (prop , _deserializeWithErrorWrapping (p , ctxt , prop ));
673
673
continue ;
674
674
}
675
-
676
- /* As per [JACKSON-313], things marked as ignorable should not be
677
- * passed to any setter
678
- */
675
+ // Things marked as ignorable should not be passed to any setter
679
676
if (_ignorableProps != null && _ignorableProps .contains (propName )) {
680
677
handleIgnoredProperty (p , ctxt , handledType (), propName );
681
678
continue ;
@@ -839,9 +836,7 @@ protected Object deserializeUsingPropertyBasedWithExternalTypeId(JsonParser p, D
839
836
if (ext .handlePropertyValue (p , ctxt , propName , null )) {
840
837
continue ;
841
838
}
842
- /* As per [JACKSON-313], things marked as ignorable should not be
843
- * passed to any setter
844
- */
839
+ // Things marked as ignorable should not be passed to any setter
845
840
if (_ignorableProps != null && _ignorableProps .contains (propName )) {
846
841
handleIgnoredProperty (p , ctxt , handledType (), propName );
847
842
continue ;
@@ -867,6 +862,14 @@ protected Object deserializeUsingPropertyBasedWithExternalTypeId(JsonParser p, D
867
862
protected Object deserializeUsingDelegateWithExternalTypeId (JsonParser p , DeserializationContext ctxt )
868
863
throws IOException
869
864
{
870
- throw ctxt .mappingException ("Combination of External Type Id, Delegating Creator not yet supported" );
865
+ // 24-Nov-2015, tatu: Something along these lines would normally work, in absence
866
+ // of external type id:
867
+ /*
868
+ Object delegate = _delegateDeserializer.deserialize(p, ctxt);
869
+ return _valueInstantiator.createUsingDelegate(ctxt, delegate);
870
+ */
871
+
872
+ throw ctxt .instantiationException (handledType (),
873
+ "Combination of External Type Id, Delegating Creator not yet supported" );
871
874
}
872
875
}
0 commit comments