-
-
Notifications
You must be signed in to change notification settings - Fork 811
Update Maven wrapper #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Maven wrapper #732
Conversation
Hi @asomov! Could you elaborate a bit on this one? Is this just a newer recommended version of wrapper or... ? Is there a blog post or article explaining what is the benefit? |
@cowtowncoder Maven Wrapper is now not from io/takari but from Apache |
Ok, but is this basically following a more up-to-date explanation of sort of "standard" Maven wrapper usage? |
@cowtowncoder yes, it is just standard way now |
@asomov Before merging this, I really need to see the instructions of how to set this up. All instructions I googled for go with Takari plug-in, f.ex:
all claim one should use:
and if there is a newer, better way, I want to know that so I can repeat the process. So... do you know of an article, blog post, github repo that shows how to do this? |
@cowtowncoder it was before it became part of Apache (it was takari).
|
It allows all the developers and the CI use exactly the same version of Maven (the same plugins) |
@asomov Ah! thank you very much. This makes sense. I'll merge this then. |
This reverts commit 2510349.
Ugh. Sorry, I botched this one, trying to rebase and ending up temporarily merging ... yeah. 3.0 stuff in, it seems. Not sure why, actually, but I guess I'll stick to cherry-picking going forward. Will use generation mechanism suggested on branch 2.13, idea being I'd like to backport this so it's not only used for |
No description provided.