Skip to content

Commit a440d70

Browse files
author
Jonathan Haber
authored
Fix failing tests (#650)
* Fix failing tests * Move test to failing directory
1 parent 5d3a256 commit a440d70

3 files changed

Lines changed: 40 additions & 26 deletions

File tree

src/test/java/com/fasterxml/jackson/core/filter/BasicGeneratorFilteringTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ private void _testSingleMatchFilteringWithPathAlternate1(boolean exclude) throws
227227
FilteringGeneratorDelegate gen = new FilteringGeneratorDelegate(_createGenerator(w),
228228
tf,
229229
Inclusion.INCLUDE_ALL_AND_PATH,
230-
false // multipleMatches
230+
true // multipleMatches
231231
);
232232
//final String JSON = "{'a':123,'array':[1,2],'ob':{'value0':2,'value':[3],'value2':'foo'},'b':true}";
233233

src/test/java/com/fasterxml/jackson/core/filter/BasicParserFilteringTest.java

Lines changed: 3 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -80,14 +80,6 @@ public TokenFilter includeElement(int index) {
8080
protected boolean _includeScalar() { return false; }
8181
}
8282

83-
static class NoArraysFilter extends TokenFilter
84-
{
85-
@Override
86-
public TokenFilter filterStartArray() {
87-
return null;
88-
}
89-
}
90-
9183
static class NoObjectsFilter extends TokenFilter
9284
{
9385
@Override
@@ -423,32 +415,18 @@ public void testNoMatchFiltering6() throws Exception
423415
assertEquals(0, p.getMatchCount());
424416
}
425417

426-
public void testValueOmitsFieldName1() throws Exception
427-
{
428-
String jsonString = aposToQuotes("{'a':123,'array':[1,2]}");
429-
JsonParser p0 = JSON_F.createParser(jsonString);
430-
FilteringParserDelegate p = new FilteringParserDelegate(p0,
431-
new NoArraysFilter(),
432-
Inclusion.INCLUDE_NON_NULL,
433-
true // multipleMatches
434-
);
435-
String result = readAndWrite(JSON_F, p);
436-
assertEquals(aposToQuotes("{'a':123}"), result);
437-
assertEquals(0, p.getMatchCount());
438-
}
439-
440418
public void testValueOmitsFieldName2() throws Exception
441419
{
442-
String jsonString = aposToQuotes("['a',{'value0':3,'b':{'value':4}}]");
420+
String jsonString = aposToQuotes("['a',{'value0':3,'b':{'value':4}},123]");
443421
JsonParser p0 = JSON_F.createParser(jsonString);
444422
FilteringParserDelegate p = new FilteringParserDelegate(p0,
445423
new NoObjectsFilter(),
446424
Inclusion.INCLUDE_NON_NULL,
447425
true // multipleMatches
448426
);
449427
String result = readAndWrite(JSON_F, p);
450-
assertEquals(aposToQuotes("['a']"), result);
451-
assertEquals(1, p.getMatchCount());
428+
assertEquals(aposToQuotes("['a',123]"), result);
429+
assertEquals(2, p.getMatchCount());
452430
}
453431

454432
public void testIndexMatchWithPath1() throws Exception
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
package com.fasterxml.jackson.failing.filter;
2+
3+
import com.fasterxml.jackson.core.BaseTest;
4+
import com.fasterxml.jackson.core.JsonFactory;
5+
import com.fasterxml.jackson.core.JsonParser;
6+
import com.fasterxml.jackson.core.filter.FilteringParserDelegate;
7+
import com.fasterxml.jackson.core.filter.TokenFilter;
8+
import com.fasterxml.jackson.core.filter.TokenFilter.Inclusion;
9+
10+
public class BasicParserFilteringTest extends BaseTest {
11+
12+
private final JsonFactory JSON_F = new JsonFactory();
13+
14+
static class NoArraysFilter extends TokenFilter
15+
{
16+
@Override
17+
public TokenFilter filterStartArray() {
18+
return null;
19+
}
20+
}
21+
22+
// for [core#649]
23+
public void testValueOmitsFieldName1() throws Exception
24+
{
25+
String jsonString = aposToQuotes("{'a':123,'array':[1,2]}");
26+
JsonParser p0 = JSON_F.createParser(jsonString);
27+
FilteringParserDelegate p = new FilteringParserDelegate(p0,
28+
new NoArraysFilter(),
29+
Inclusion.INCLUDE_NON_NULL,
30+
true // multipleMatches
31+
);
32+
String result = readAndWrite(JSON_F, p);
33+
assertEquals(aposToQuotes("{'a':123}"), result);
34+
assertEquals(0, p.getMatchCount());
35+
}
36+
}

0 commit comments

Comments
 (0)