Skip to content

Commit 1928b07

Browse files
committed
Minor test improvements
1 parent aa5c887 commit 1928b07

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

src/test/java/com/fasterxml/jackson/failing/read/LocationOfError1173Test.java

+11-6
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,8 @@ public enum ParserVariant
6666
true,
6767
false,
6868
true
69-
);
69+
)
70+
;
7071

7172
ParserVariant(
7273
ParserGenerator parserGenerator,
@@ -105,15 +106,15 @@ public JsonParser createParser(String input) throws Exception
105106
),
106107
new InvalidJson(
107108
"Comma after key in object property",
108-
"{\"invalid\", \"json\"}",
109+
a2q("{'invalid', 'json'}"),
109110
10,
110111
10,
111112
1,
112113
11
113114
),
114115
new InvalidJson(
115116
"Missing comma between object properties",
116-
"{\"key1\":\"value1\" \"key2\":\"value2\"}",
117+
a2q("{'key1':'value1' 'key2':'value2'}"),
117118
17,
118119
17,
119120
1,
@@ -269,18 +270,22 @@ public void testParserBackendWithInvalidJson(ParserVariant variant, InvalidJson
269270

270271
JsonLocation location = e.getLocation();
271272
assertEquals(invalidJson.lineNr, location.getLineNr());
273+
final String msg = e.getOriginalMessage();
272274

273275
if (variant.supportsByteOffset)
274276
{
275-
assertEquals("Incorrect byte offset", invalidJson.byteOffset, location.getByteOffset());
277+
assertEquals("Incorrect byte offset (for '"+msg+"')",
278+
invalidJson.byteOffset, location.getByteOffset());
276279
}
277280
if (variant.supportsCharOffset)
278281
{
279-
assertEquals("Incorrect char offset",invalidJson.charOffset, location.getCharOffset());
282+
assertEquals("Incorrect char offset (for '"+msg+"')",
283+
invalidJson.charOffset, location.getCharOffset());
280284
}
281285
if (variant.supportsColumnNr)
282286
{
283-
assertEquals("Incorrect column", invalidJson.columnNr, location.getColumnNr());
287+
assertEquals("Incorrect column (for '"+msg+"')",
288+
invalidJson.columnNr, location.getColumnNr());
284289
}
285290
}
286291
}

0 commit comments

Comments
 (0)