Unify handling of leading (non-compliant) plus sign: dropped for all values

(ideally would include for all but difficult currently)

Author: cowtowncoder

src/main/java/com/fasterxml/jackson/core/json/ReaderBasedJsonParser.java

@@ -1331,7 +1331,7 @@ protected final JsonToken _parseFloatThatStartsWithPeriod() throws IOException {
     }
 
     protected final JsonToken _parseFloatThatStartsWithPeriod(final boolean neg,
-            final boolean prependSign)
+            final boolean hasSign)
         throws IOException
     {
         // [core#611]: allow optionally leading decimal point
@@ -1343,8 +1343,9 @@ protected final JsonToken _parseFloatThatStartsWithPeriod(final boolean neg,
         //    (leading sign, period) within same buffer. Caller must ensure this is
         //    the case.
         //    Little bit suspicious of code paths that would go to "_parseNumber2(...)"
+        // 27-Jun-2022, tatu: [core#784] would add plus here too but not yet
         int startPtr = _inputPtr - 1;
-        if (prependSign) {
+        if (neg) {
             --startPtr;
         }
         return _parseFloat(INT_PERIOD, startPtr, _inputPtr, neg, 0);

src/main/java/com/fasterxml/jackson/core/json/UTF8DataInputJsonParser.java

@@ -1006,7 +1006,7 @@ protected final JsonToken _parseFloatThatStartsWithPeriod() throws IOException {
     }
 
     protected final JsonToken _parseFloatThatStartsWithPeriod(final boolean neg,
-            final boolean prependSign)
+            final boolean hasSign)
         throws IOException
     {
         // [core#611]: allow optionally leading decimal point
@@ -1015,8 +1015,9 @@ protected final JsonToken _parseFloatThatStartsWithPeriod(final boolean neg,
         }
         final char[] outBuf = _textBuffer.emptyAndGetCurrentSegment();
         int outPtr = 0;
-        if (prependSign) {
-            outBuf[outPtr++] = neg ? '-' : '+';
+        // 27-Jun-2022, tatu: [core#784] would add plus here too but not yet
+        if (neg) {
+            outBuf[outPtr++] = '-';
         }
         return _parseFloat(outBuf, outPtr, INT_PERIOD, neg, 0);
     }

src/main/java/com/fasterxml/jackson/core/json/UTF8StreamJsonParser.java

@@ -1435,7 +1435,7 @@ protected final JsonToken _parseFloatThatStartsWithPeriod() throws IOException {
     }
 
     protected final JsonToken _parseFloatThatStartsWithPeriod(final boolean neg,
-            final boolean prependSign)
+            final boolean hasSign)
         throws IOException
     {
         // [core#611]: allow optionally leading decimal point
@@ -1444,8 +1444,9 @@ protected final JsonToken _parseFloatThatStartsWithPeriod(final boolean neg,
         }
         final char[] outBuf = _textBuffer.emptyAndGetCurrentSegment();
         int outPtr = 0;
-        if (prependSign) {
-            outBuf[outPtr++] = neg ? '-' : '+';
+        // 27-Jun-2022, tatu: [core#784] would add plus here too but not yet
+        if (neg) {
+            outBuf[outPtr++] = '-';
         }
         return _parseFloat(outBuf, outPtr, INT_PERIOD, neg, 0);
     }

src/test/java/com/fasterxml/jackson/core/read/NonStandardNumberParsingTest.java

@@ -144,8 +144,6 @@ private void _testLeadingPlusSignInDecimalAllowed(JsonFactory f, int mode) throw
             assertEquals(JsonToken.VALUE_NUMBER_INT, p.nextToken());
             assertEquals(125.0, p.getValueAsDouble());
             assertEquals("125", p.getDecimalValue().toString());
-            // 27-Jun-2022, tatu: As per [core#784] this SHOULD include leading
-            //    plug sign
             assertEquals("125", p.getText());
         }
         try (JsonParser p = createParser(f, mode, " +0.125 ")) {
@@ -158,12 +156,7 @@ private void _testLeadingPlusSignInDecimalAllowed(JsonFactory f, int mode) throw
             assertEquals(JsonToken.VALUE_NUMBER_FLOAT, p.nextToken());
             assertEquals(0.125, p.getValueAsDouble());
             assertEquals("0.125", p.getDecimalValue().toString());
-            // 27-Jun-2022, tatu: As per [core#784] this SHOULD include leading
-            //    plug sign. But worse, looks like sometimes it does sometimes not
-            final String text = p.getText();
-            if (!"+.125".equals(text) && !".125".equals(text)) {
-                fail("Bad textual representation: ["+text+"]");
-            }
+            assertEquals(".125", p.getText());
         }
     }