Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: v2.2.0 -> 2.5.7 triggers the onChangeText Input event after selecting a location #962

Open
3 of 4 tasks
KrisLau opened this issue Jan 20, 2025 · 0 comments
Open
3 of 4 tasks
Labels

Comments

@KrisLau
Copy link

KrisLau commented Jan 20, 2025

Describe the bug

I was working on updating the packages in my project but for some reason I noticed that upgrading this package causes my validation check to fail because of the onChangeText firing additional times when upgrading the package to v2.5.7 from 2.2.0

Reproduction - (required - issue will be closed without this)

You dont need the api key to test. Just test in its current state (v2.2.0) and then upgrade the package in the package.json to 2.5.7
https://snack.expo.dev/@kris_lau/maps-autocomplete?platform=ios

In v2.2.0 (and 2.5.1 from what I can tell) you should see this:
Image

In v2.5.7 you should see the onChangeText fired after selecting the item from the list which sets the isLocationValid to false. v2.5.7 doesn't seem to work in the snack though, it crashes with the crypto.getRandomValues() not supported error and on my project using the same code as the snack causes a Maximum update depth exceeded error:
Image

Additional context

  • Library Version: [2.2.0 & 2.57]

  • React Native Version: [0.76.6]

  • iOS

  • Android

  • Web

If you are using expo please indicate here:

  • I am using expo (bare workflow)

Add any other context about the problem here, screenshots etc

@KrisLau KrisLau added the bug label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant