Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[orchestra2md] Redundant newline for conversion of DC terms #67

Open
kleihan opened this issue Sep 5, 2022 · 2 comments
Open

[orchestra2md] Redundant newline for conversion of DC terms #67

kleihan opened this issue Sep 5, 2022 · 2 comments
Assignees
Labels
bug Something isn't working fixed Issue has been resolved, awaits testing

Comments

@kleihan
Copy link
Member

kleihan commented Sep 5, 2022

DC terms table is not created correctly in Tablature v1.0.2. The values of the meta-data elements are created as new lines in markdown instead of continuing on the same line as the element name. The resulting table cannot be rendered correctly, e.g. by Pandoc.

| Term        | Value                                                             |
|-------------|-------------------------------------------------------------------|
| title       | 
            FIX.Latest_EP272                                     |
| created     | 
            2022-08-15T16:15:49.035692                           |
| date        | 
            2022-08-04T15:17:49Z                                 |
| rights      | 
            Copyright (c) FIX Protocol Ltd. All Rights Reserved. |
| conformsTo  | 
            Orchestra v1.0                                       |
| source      | 
            FIX Unified Repository 2010 Edition                  |
| contributor | playlist
                                                         |
| date        | 2022-09-05T18:39:31.877Z
                                         |

The table should be created as follows in markdown:

| Term        | Value                                                |
|-------------|------------------------------------------------------|
| title       | FIX.Latest_EP272                                     |
| created     | 2022-08-15T16:15:49.035692                           |
| date        | 2022-08-04T15:17:49Z                                 |
| rights      | Copyright (c) FIX Protocol Ltd. All Rights Reserved. |
| conformsTo  | Orchestra v1.0                                       |
| source      | FIX Unified Repository 2010 Edition                  |
| contributor | playlist                                             |
| date        | 2022-09-05T18:39:31.877Z                             |
@kleihan kleihan added the bug Something isn't working label Sep 5, 2022
@donmendelson
Copy link
Member

Problem not reproduced in unit test

| Term      | Value                                                |
|-----------|------------------------------------------------------|
| title     | Orchestra                                            |
| creator   | unified2orchestra.xslt script                        |
| publisher | FIX Trading Community                                |
| date      | 2020-07-19T09:28:08.308Z                             |
| format    | Orchestra schema                                     |
| source    | FIX Unified Repository                               |
| rights    | Copyright (c) FIX Protocol Ltd. All Rights Reserved. |

@kleihan
Copy link
Member Author

kleihan commented Sep 6, 2022

I think you used the XML created by the XSLT script, not by Python. Please try again with the XML below:

    <fixr:metadata>
        <dcterms:title>
            FIX.Latest_EP273</dcterms:title>
        <dcterms:created>
            2022-08-29T14:23:11.894478</dcterms:created>
        <dcterms:date>
            2022-08-23T13:14:11Z</dcterms:date>
        <dcterms:rights>
            Copyright (c) FIX Protocol Ltd. All Rights Reserved.</dcterms:rights>
        <dcterms:conformsTo>
            Orchestra v1.0</dcterms:conformsTo>
        <dcterms:source>
            FIX Unified Repository 2010 Edition</dcterms:source>
    </fixr:metadata>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Issue has been resolved, awaits testing
Projects
Status: No status
Development

No branches or pull requests

2 participants