Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[md2orchestra] invalid treatment of supported attribute #63

Open
donmendelson opened this issue Feb 1, 2022 · 1 comment
Open

[md2orchestra] invalid treatment of supported attribute #63

donmendelson opened this issue Feb 1, 2022 · 1 comment
Labels
bug Something isn't working fixed Issue has been resolved, awaits testing

Comments

@donmendelson
Copy link
Member

donmendelson commented Feb 1, 2022

Reported by Jörg Thonnes in FIX Forum:

currently, I started to produce a specific FIX Orchestra file in both XML and Markdown formats to describe our FIX Trading Adapter.

To indicate that some specific code set values are forbidden or unsupported, I used the supported attribute of the fixr:codeset element. The resulting Markdown table lacks the column, though.

If I add the column “supported” to the Markdown table, the result is a new XML sub-element:

<fixr:appinfo purpose="supported">forbidden</fixr:appinfo>

@donmendelson
Copy link
Member Author

donmendelson commented Feb 1, 2022

Seems like a bug. md2orchestra adds an appinfo element for any column name that it does not recognize as an Orchestra attribute. This is by design–it allows a firm to extend Orchestra in its ROE in any way it chooses. However, supported is a standard Orchestra attribute, so it should not have been treated that way.

Codesets can be treated in two ways. One is to only include the codes that are actually allowed by the ROE. The other way is to explicitly enumerate both supported and unsupported codes. For example, in a codeset for order type, you may want to explicitly say that Stop-Limit is not supported for an asset class. You do that by setting supported="forbidden" for that code, indicating that if that order type was requested, the order would be rejected.

The valid values of supported attribute are supported, forbidden, and ignored – supported is the default. The attribute is valid for messages and any of their elements. The ignored case indicates that a value is permitted but not validated.

@donmendelson donmendelson added the bug Something isn't working label Feb 1, 2022
@kleihan kleihan added the fixed Issue has been resolved, awaits testing label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Issue has been resolved, awaits testing
Projects
Status: No status
Development

No branches or pull requests

2 participants