Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent capitalization of keywords True and False #25

Open
kleihan opened this issue Apr 16, 2021 · 2 comments
Open

Inconsistent capitalization of keywords True and False #25

kleihan opened this issue Apr 16, 2021 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@kleihan
Copy link
Member

kleihan commented Apr 16, 2021

Keywords true and false are sometimes capitalized, seems inconsistent. They are also not always set in quotation marks.

  • Chapter 3.3: ... which means it evaluates to "true" when one and only one of its operands is true. If none or more than one of its operands is true then XOR is false.
  • Chapter 3.8.8: <Edit field="c_LegParamA" operator="EQ" value="True"/>
  • Definition of Parameter/@trueWireValue: Defines the value with which to populate the FIX message when the boolean parameter is True.
  • ...

Suggest to define single syntax and hamronize.

@donmendelson
Copy link
Member

If the attribute is defined as boolean in the XML schema, the legal values are lower case "true", "false", 1 (which indicates true), and 0 (which indicates false).

@kleihan
Copy link
Member Author

kleihan commented Apr 16, 2021

FIXatdl also defines two boolean types (Chapter 6), lowercase from XML Schema and uppercase from FIXML. Why are both needed by FIXatdl?

@kleihan kleihan added the documentation Improvements or additions to documentation label Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants