Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repository schema] Allow names in correlation and assignment references #187

Closed
kleihan opened this issue Aug 31, 2023 · 0 comments · Fixed by #226 or FIXTradingCommunity/fix-orchestra-spec#54
Assignees
Labels
ERRATA Errors and omissions, inconsistencies

Comments

@kleihan
Copy link
Member

kleihan commented Aug 31, 2023

Issue #136 supports optional names in element references. This should also be supported for correlation and assignment references used in message responses. The following example adds names to all references

<fixr:response name="orderAck">
	<fixr:messageRef  id="9" name="ExecutionReport" msgType="8" implMaxOccurs="1" implMinOccurs="1">
		<fixr:identifiers>
			<fixr:correlate id="11" name="ClOrdID"/>
			<fixr:correlate id="2422" name="OrderRequestID"/>
			<fixr:assign id="37" name="OrderID"/>
		</fixr:identifiers>
	</fixr:messageRef>
</fixr:response>

The schema uses identifierType for these references. It is proposed to add a name attribute as follows:

	<xs:complexType name="identifierType">
		<xs:attribute name="id" type="fixr:id_t" use="required">
			<xs:annotation>
				<xs:documentation>Field ID assigned or correlated in a message reference</xs:documentation>
			</xs:annotation>
		</xs:attribute>
		<xs:attribute name="name" type="fixr:Name_t">
			<xs:annotation>
				<xs:documentation>Name is optional for convenience, but it is not enforced by referential integrity. Only the ID of the referred object is authoritative.</xs:documentation>
			</xs:annotation>
		</xs:attribute>
		<xs:attribute name="sourceId" type="fixr:id_t">
			<xs:annotation>
				<xs:documentation>Field ID correlated from source message. If not present, assumed to be same tag as 'id'.</xs:documentation>
			</xs:annotation>
		</xs:attribute>
	</xs:complexType>
@kleihan kleihan self-assigned this Aug 31, 2023
@kleihan kleihan added ERRATA Errors and omissions, inconsistencies and removed enhancement labels Aug 21, 2024
kleihan added a commit that referenced this issue Sep 5, 2024
@kleihan kleihan linked a pull request Sep 5, 2024 that will close this issue
@kleihan kleihan removed a link to a pull request Sep 5, 2024
@kleihan kleihan linked a pull request Sep 5, 2024 that will close this issue
@kleihan kleihan moved this to In progress in Orchestra v1.1 RC2 Sep 12, 2024
kleihan added a commit that referenced this issue Nov 4, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Orchestra v1.1 RC2 Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ERRATA Errors and omissions, inconsistencies
Projects
Status: Done
1 participant