Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repository schema] Remove (initially: add) repository attribute for application version (initially: extension) ID #186

Closed
kleihan opened this issue Aug 29, 2023 · 2 comments · Fixed by #240 or FIXTradingCommunity/fix-orchestra-spec#58
Assignees
Labels
DeFIXify Remove FIX-specific elements

Comments

@kleihan
Copy link
Member

kleihan commented Aug 29, 2023

Orchestra has a number of attributes for the <repository> element. One of them (applVerId) is for the application version (not to be confused with the repository version attribute version). It is proposed to add a new attribute applExtId to fully support FIX versioning covered by the FIX fields ApplVerID(1128) and ApplExtID(1156) in the StandardHeader component.

<xs:attribute name="applVerId" type="xs:string"/>
<xs:attribute name="applExtId" type="xs:integer"/>
@kleihan
Copy link
Member Author

kleihan commented Nov 10, 2023

This is linked to the existing issue FIXTradingCommunity/fix-orchestra-spec#46 about DC terms to use. That may be a better approach than adding attributes to the root element.

@kleihan kleihan added DeFIXify Remove FIX-specific elements and removed enhancement labels Aug 21, 2024
@kleihan kleihan moved this to In progress in Orchestra v1.1 RC2 Sep 12, 2024
@kleihan
Copy link
Member Author

kleihan commented Oct 9, 2024

The repository element has a generic version attribute for the schema. Rather than having explicit attributes for the application, the generic DC terms should cover this information, see FIXTradingCommunity/fix-orchestra-spec#46.

Proposal is now to remove the existing applVerId attribute instead of adding a second, more granular one.

@kleihan kleihan linked a pull request Oct 9, 2024 that will close this issue
@kleihan kleihan changed the title [repository schema] Add repository attribute for application extension ID [repository schema] Remove (initially: add) repository attribute for application extension ID Nov 4, 2024
kleihan added a commit that referenced this issue Nov 4, 2024
[#186] Remove applVerId instead of adding applExtId
@kleihan kleihan changed the title [repository schema] Remove (initially: add) repository attribute for application extension ID [repository schema] Remove (initially: add) repository attribute for application version (initially: extension) ID Nov 11, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Orchestra v1.1 RC2 Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeFIXify Remove FIX-specific elements
Projects
Status: Done
1 participant