Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor request-retry to be asynchronous up to the retry strategy #103

Open
lkuffo opened this issue Apr 9, 2019 · 1 comment
Open

Comments

@lkuffo
Copy link

lkuffo commented Apr 9, 2019

Is there any way to implement a custom retryStrategy which needs to be asynchronous?

Let's say, for example, my mustRetry option depends on some value that I have to query on a database.

@FGRibreau
Copy link
Owner

Hello!

Ahhh I was so young :)
Indeed the whole API should be asynchronous (I did not make the mistake in the last libs), I will accept a PR (with tests) that will check if the yield value from the strategy is a promise and handle that accordingly 👍

@FGRibreau FGRibreau reopened this Apr 24, 2019
@FGRibreau FGRibreau changed the title Asynchronous Custom Retry Strategy Refactor request-retry to be asynchronous up to the retry strategy May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants