-
-
Notifications
You must be signed in to change notification settings - Fork 68
ConstantValue and Parameter #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is Firedrake (or FEniCSx for that matter) using |
Yes, we are using ConstantValue. As soon as you start doing multiple domain calculations, having to associate a domain with a constant is a pain. We concede the differentiation point. For the moment, differentiation WRT to a |
I think AbstractParameter should have a dtype as input, as it could be: |
Note that enabling differentiation with respect to a |
As discussed at SysGenX meeting, we should:
ConstantValue
toAbstractParameter
. This is the base class for parameters (previously constants) without a domainParameter
class that inherits fromAbstractParameter
to represent a parameter with an unknown valueConstant
as it is: representing a constant over a domainThe text was updated successfully, but these errors were encountered: