[Due for payment 2025-02-28] 2FA - Refreshing the page and click go back takes to settings page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.1.3-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #54404
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: macOS/chrome
App Component: User Settings

Action Performed:

1. Go to https://staging.new.expensify.com
2. Go to Settings > Security > 2FA
3. Click on Copy > Next
4. On step two page refresh the page
5. Click on the back button

Expected Result:

User is navigated to step 1 page

Actual Result:

User is taken to the settings page

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6749715_1740113885236.Screen_Recording_2025-02-21_at_7.46.58_in_the_morning.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @michaelkwardrop

[melvin-bot]

Triggered auto assignment to @michaelkwardrop (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User is taken to the settings page

What is the root cause of that problem?

We don't add backToRoute in this goBack

App/src/pages/settings/Security/TwoFactorAuth/VerifyPage.tsx

Line 83 in e0e1529

onBackButtonPress={Navigation.goBack}

What changes do you think we should make in order to solve the problem?

We should add the default route as ROUTES.SETTINGS_2FA_ROOT.getRoute()

      onBackButtonPress={Navigation.goBack(ROUTES.SETTINGS_2FA_ROOT.getRoute())}

App/src/pages/settings/Security/TwoFactorAuth/VerifyPage.tsx

Line 83 in e0e1529

onBackButtonPress={Navigation.goBack}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[blazejkustra]

This is a regression from my PR. I'm going to look into it now!

[blazejkustra]

PR is up cc @shubham1206agra

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.3-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix goBack functionality on the 'Verify' step of two-factor verification. #57246

If no regressions arise, payment will be issued on 2025-02-28. 🎊

For reference, here are some details about the assignees on this issue:

• @blazejkustra does not require payment (Contractor)
• @shubham1206agra requires payment through NewDot Manual Requests

[melvin-bot]

@shubham1206agra @michaelkwardrop @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]