Error is not cleared after selecting an option in What type of account is this? page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.97-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): expense

Action Performed:

1. Go to account settings
2. Click on "add bank account"
3. Select any other country
4. In the following page enter any random numbers and click Next
5. In What type of account is this page click "Next" without selecting any option
6. Observe the error message
7. Select any option

Expected Result:

Error message is cleared

Actual Result:

Message is not cleared

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.982.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-13 23:29:20 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error is not cleared after selecting an option in What type of account is this? page

What is the root cause of that problem?

• We are not clearing the error when selecting an option.
  

  App/src/pages/settings/Wallet/InternationalDepositAccount/substeps/AccountType.tsx

  Lines 38 to 46 in f760986

  	const onSelectionChange = useCallback(
  	(country: Option) => {
  	if (!isEditing) {
  	setDraftValues(ONYXKEYS.FORMS.INTERNATIONAL_BANK_ACCOUNT_FORM, {[CONST.CORPAY_FIELDS.ACCOUNT_TYPE_KEY]: country.value});
  	}
  	setCurrentAccountType(country.value);
  	},
  	[isEditing],
  	);

What changes do you think we should make in order to solve the problem?

• Call setError(undefined); inside onSelectionChange.
• We should also look for similar components with same issue and resolve those also.
• We can also remove this line.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

[mkzie2]

This will be fixed here #56464

[NicMendonca]

Thanks @mkzie2 ! closing