Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports - Report name for thread in workspace chat is workspace name instead of thread title #56530

Closed
8 tasks done
mitarachim opened this issue Feb 7, 2025 · 9 comments
Closed
8 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.95-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Search

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open 1:1 DM.
  3. Send a message.
  4. Right click on the message > Reply in thread.
  5. Send a reply in thread.
  6. Go to Reports > Chats.
  7. Note that the report name for thread in 1:1 DM is the thread header title.
  8. Go to workspace chat.
  9. Send a message.
  10. Right click on the message > Reply in thread.
  11. Send a reply in thread.
  12. Go to Reports > Chats.

Expected Result:

The report name for thread in workspace chat should be the thread header title.

Actual Result:

The report name for thread in workspace chat is the workspace name.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6736021_1738918541239.20250207_165205.mp4

View all open jobs on GitHub

@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Feb 7, 2025
Copy link

melvin-bot bot commented Feb 7, 2025

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 7, 2025

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 7, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@NJ-2020
Copy link
Contributor

NJ-2020 commented Feb 7, 2025

I think this the expected

#50135

@luacmartins
Copy link
Contributor

Not a blocker. @JmillsExpensify @trjExpensify can you confirm the expected behavior here? I kinda like having the top level report as the context instead of the thread message. Either way, I don't think this is a blocker.

@melvin-bot melvin-bot bot removed the Overdue label Feb 10, 2025
@luacmartins luacmartins added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 10, 2025
@trjExpensify
Copy link
Contributor

Yeah, I'm pretty sure that's what we said for the v1 here, because otherwise we need to compute a lot of titles like system messages and stuff wasn't it?

@luacmartins
Copy link
Contributor

Yea, that's what I thought as well. So we can just close this for now?

@trjExpensify
Copy link
Contributor

Yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants