[Due for payment 2025-02-19] [Due for payment 2025-02-18] Android & iOS - Reports - App crashes when tapping Filters icon after opening View transactions from card page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.95-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Search

Action Performed:

Precondition:

• User is workspace owner and has assigned themselves a virtual card.

1. Launch ND or hybrid app.
2. Go to Account settings > Wallet.
3. Tap Report virtual card fraud.
4. Tap Deactivate card.
5. Enter magic code.
6. Tap Got it, thanks.
7. Tap View transactions.
8. On Reports page, tap Filters icon.

Expected Result:

App will not crash and Filters page will open.

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/7f26cc8e-d4a5-429d-a2c0-8b75fc071ff3
Bug6735975_1738913614019!log.txt

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

Not repro on production

screen-20250207-095051.mp4

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes.

What is the root cause of that problem?

After deactivating the card, card has only a field {isLoading: false}. Then the app crashes when we call getBankName function here with card.bank is undefined

App/src/libs/CardUtils.ts

Line 329 in 33a03bf

const feedKey = (Object.keys(feedNamesMapping) as CompanyCardFeed[]).find((feed) => feedType.startsWith(feed));

App/src/libs/CardUtils.ts

Line 85 in 33a03bf

const humanReadableBankName = card.bank === CONST.EXPENSIFY_CARD.BANK ? CONST.EXPENSIFY_CARD.BANK : getBankName(card.bank as CompanyCardFeed);

What changes do you think we should make in order to solve the problem?

We can also return early if card.cardID is undefined or we shouldn't cast the type here, change the type of feedType to undefined and then return early in getBankName function if feedType is undefined.

App/src/libs/CardUtils.ts

Lines 81 to 83 in 33a03bf

	if (!card) {
	return '';
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android & iOS - Reports - App crashes when tapping Filters icon after opening View transactions from card page

What is the root cause of that problem?

As we can see from the error

In line 219, we're trying to convert the cardID property to string which doesn't exist in card value which cause the app to crash

App/src/pages/Search/AdvancedSearchFilters.tsx

Lines 217 to 219 in e7b38b9

	return filterValue
	? Object.values(cards)
	.filter((card) => filterValue.includes(card.cardID.toString()))

The card value is taken from here

App/src/pages/Search/AdvancedSearchFilters.tsx

Lines 103 to 105 in e7b38b9

	cardID: {
	getTitle: getFilterCardDisplayTitle,
	description: 'common.card' as const,

And getTitle is invoked that cardList is passed here

App/src/pages/Search/AdvancedSearchFilters.tsx

Lines 482 to 486 in e7b38b9

	} else if (key === CONST.SEARCH.SYNTAX_FILTER_KEYS.CARD_ID) {
	if (!shouldDisplayCardFilter) {
	return;
	}
	filterTitle = baseFilterConfig[key].getTitle(searchAdvancedFilters, allCards);

And allCards value is taken from mergeCardListWithWorkspaceFeeds function

In mergeCardListWithWorkspaceFeeds function we don't filter any card that doesn't have any cardID like we do for workspace card feeds

App/src/libs/CardUtils.ts

Lines 101 to 110 in e7b38b9

	function mergeCardListWithWorkspaceFeeds(workspaceFeeds: Record<string, WorkspaceCardsList | undefined>, cardList = allCards, shouldExcludeCardHiddenFromSearch = false) {
	const feedCards: CardList = {};
	Object.keys(cardList).forEach((cardKey) => {
	const card = cardList[cardKey];
	if (shouldExcludeCardHiddenFromSearch && isCardHiddenFromSearch(card)) {
	return;
	}
	feedCards[cardKey] = card;
	});

App/src/libs/CardUtils.ts

Lines 114 to 116 in e7b38b9

	if (!isCard(card) || (shouldExcludeCardHiddenFromSearch && isCardHiddenFromSearch(card))) {
	return;
	}

What changes do you think we should make in order to solve the problem?

We should filter the card like we do for workspace card feeds

Object.keys(cardList).forEach((cardKey) => {
    const card = cardList[cardKey];
    if (shouldExcludeCardHiddenFromSearch && isCardHiddenFromSearch(card) || !isCard(card)) {
        return;
    }
    feedCards[cardKey] = card;
});

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We should create a test function an pass a cardList without a cardID and make sure the mergeCardListWithWorkspaceFeeds function returns nothing

What alternative solutions did you explore? (Optional)

[Kicu]

Please assign me to this one and I can fix it, we had done a lot of work with Search and card filters

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[Julesssss]

Assigning for C+ review first.

[Julesssss]

Hey @Kicu, assigned. Thanks.

I also directly assigned @ikevin127 for C+ as he is online

[Julesssss]

Fix on staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.95-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Do not return empty card Objects for AdvancedFilters #56600

If no regressions arise, payment will be issued on 2025-02-18. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)
• @ikevin127 requires payment (Needs manual offer from BZ)

[melvin-bot]

@ikevin127 @alexpensify @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[Kicu]

went super smooth 👍

[ikevin127]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/55900/files#r1951480523.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A.

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition: User is workspace owner and has assigned themselves a virtual card.

1. Go to Account settings > Wallet.
2. Tap on virtual card > Report virtual card fraud.
3. Tap Deactivate card.
4. Enter magic code.
5. Tap Got it, thanks.
6. Tap View transactions.
7. Once on Reports page, verify that tapping the Filters icon and opening the Filters page won't crash the app.

Do we agree 👍 or 👎.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.96-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Do not return empty card Objects for AdvancedFilters #56600

If no regressions arise, payment will be issued on 2025-02-19. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)
• @ikevin127 requires payment (Needs manual offer from BZ)

[melvin-bot]

@ikevin127 @alexpensify @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]