Reports-Extra saved search action menu briefly appears at the top left corner of Reports page

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.95-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3284916
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: MacBook Sonoma 14.1 Chrome
App Component: Search

Action Performed:

1. Navigate to staging.new.expensify.com and log in with gmail account
2. Open Reports tab/ Expenses and create a saved search
3. Click on the 3 dot icon next to the saved search

Expected Result:

Only one action menu for a saved search appears on the page after clicking on 3 dots icon

Actual Result:

Extra saved search action menu briefly appears at the top left corner of Reports page. The issue happens when user clicks on 3 dot menu for the first time after entering the page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6735756_1738888655473.Saved_search_menu.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Extra saved search action menu briefly appears at the top left corner of Reports page. The issue happens when user clicks on 3 dot menu for the first time after entering the page.

What is the root cause of that problem?

The initial position is set here

In SavedSearchItemThreeDotMenuProps, we just calculate the threeDot position when users click on the icon

App/src/pages/Search/SavedSearchItemThreeDotMenu.tsx

Lines 26 to 32 in d687284

	onIconPress={() => {
	threeDotsMenuContainerRef.current?.measureInWindow((x, y, width) => {
	setThreeDotsMenuPosition({
	horizontal: x + width,
	vertical: y,
	});
	});

At the same time, we also trigger open the popover so it will use the initial three dot position to show first, when the 3 dot position is updated, the popover will show correctly

What changes do you think we should make in order to solve the problem?

We shouldn't calculate the 3 dot position on click, instead we can calculate on layout change like what we did on BaseEducationalTooltip

View
            ref={threeDotsMenuContainerRef}
            style={[isDisabledItem && styles.pointerEventsNone]}
            onLayout={(e) => {
                const target = e.target || e.nativeEvent.target;
                target?.measureInWindow((x, y, width) => {
                    setThreeDotsMenuPosition({
                        horizontal: x + width,
                        vertical: y,
                    });
                });
            }}
        >

We also need to consider other 3 dot components.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

UI issue

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.