Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please create a new 1P vault called Mobile-Deploy-CI-Test #56493

Open
roryabraham opened this issue Feb 6, 2025 · 4 comments
Open

Please create a new 1P vault called Mobile-Deploy-CI-Test #56493

roryabraham opened this issue Feb 6, 2025 · 4 comments
Assignees

Comments

@roryabraham
Copy link
Contributor

Problem

We are working on setting up https://github.com/Expensify/App-Test-Fork for full dry-run e2e tests of the NewDot deploy cycle, with little to no permanent code diff between the fork and the upstream.

To access secrets in NewDot CI/CD, we use 1P. We want a separate test vault so that we can set up all our dummy credentials without risking accidentally using production secrets.

Solution

Please set up a new 1P vault called Mobile-Deploy-CI-Test. ring access level can match Mobile-Deploy-CI vault

Copy link

melvin-bot bot commented Feb 6, 2025

Triggered auto assignment to @robertjchen (ring0), see https://stackoverflow.com/c/expensify/questions/6102 for more details.

@robertjchen
Copy link
Contributor

@roryabraham done, let me know if you can see it 👍

@roryabraham
Copy link
Contributor Author

Nice, yes I see it thanks

@roryabraham
Copy link
Contributor Author

roryabraham commented Feb 7, 2025

@robertjchen can you please:

  1. install the 1Password CLI (if needed)

  2. Create a service account token that can access this vault with:

    op service-account create "Mobile-Deploy-CI-Test" --expires-in 90d --vault Mobile-Deploy-CI-Test:read_items
  3. Save the token as a password in the Mobile-Deploy-CI-Test vault

  4. (optional) Add the token as a repo secret called OP_SERVICE_ACCOUNT_TOKEN with in the App-Test-Fork repo with this link: https://github.com/Expensify/App-Test-Fork/settings/secrets/actions/new

Thanks! (I attempted this but got a 403 trying to create the service account)

@roryabraham roryabraham reopened this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants