-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Can't Hold card expenses #56444
Comments
Job added to Upwork: https://www.upwork.com/jobs/~021887314499991264995 |
Triggered auto assignment to @dylanexpensify ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox ( |
@dylanexpensify Gonna start it as |
@garrettmknight Actually this a BE issue App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx Lines 358 to 361 in a8daefb
All the conditions were matched but only the last one is returning false which is canHoldUnholdReportAction(moneyRequestAction).canHoldRequest
Inside Lines 3639 to 3642 in a8daefb
Lines 3644 to 3649 in a8daefb
App/src/libs/ReportActionsUtils.ts Lines 161 to 163 in a8daefb
But since the BE is returning the action name as PREVIEW instead of IOU and some properties regarding to IOU is not exists like IOUReportID, so the above function But I think maybe we can also solve this by using workaround solution App/src/libs/ReportActionsUtils.ts Lines 161 to 163 in a8daefb
And instead of IOUReportID we can check if the action name is preview then we will use the report id and so on.. But yeah this workaround solution may work but maybe it cause any error/bugs in the future |
Yes i'll review this comment within few hours |
We have a logic check for the |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: N/A
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation (hyperlinked to channel name): #expense
Preconditions:
Action Performed:
Expected Result:
The approver should see the option to Hold an expense
Actual Result:
The approver doesn't see the option to Hold an expnese
Workaround:
No workaround.
Platforms:
Which of our officially supported platforms is this issue occurring on?
All
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @suneoxThe text was updated successfully, but these errors were encountered: