Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-19] Extract validateActor job to separate file #56233

Open
jnowakow opened this issue Feb 3, 2025 · 6 comments
Open
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Improvement Item broken or needs improvement. Weekly KSv2

Comments

@jnowakow
Copy link
Contributor

jnowakow commented Feb 3, 2025

Job validateActor is used in many workflows (deploy.yml, testBuild.yml etc...). It's duplicated in all those workflows. We can extract it to .github/actions/composite for better readability and maintenance of CI.

@jnowakow
Copy link
Contributor Author

jnowakow commented Feb 3, 2025

cc @Julesssss @mountiny

@Julesssss
Copy link
Contributor

Lets check in with @roryabraham. He's refactoring some workflows, let's just make sure there's no overlap here.

@roryabraham
Copy link
Contributor

I'm fine with this change, good suggestion 👍🏼

@roryabraham
Copy link
Contributor

Then again, it looks like the validation we're doing is not always the same. There are several different behaviors:

  • that the actor is a deployer
  • that the actor has write access
  • that the actor is an Expensify employee (since all Expensify employees have write access, and nobody who's not an employee has write access, this is redundant with the previous step

So really only two

@roryabraham roryabraham self-assigned this Feb 5, 2025
@roryabraham roryabraham added Monthly KSv2 Improvement Item broken or needs improvement. labels Feb 5, 2025
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Feb 5, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 7, 2025
@melvin-bot melvin-bot bot changed the title Extract validateActor job to separate file [Due for payment 2025-02-19] Extract validateActor job to separate file Feb 12, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 12, 2025
Copy link

melvin-bot bot commented Feb 12, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 12, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.96-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-19. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants