Add closed cards to card filter on reports page

[joekaufmanexpensify]

Context

Company credit cards are often canceled because there was a dispute, the card expires, the employee leaves, etc.. If the card incurred any transactions beforehand, the company still needs to reconcile them.

Problem

If a credit card is closed/canceled in New Expensify (terminated for Expensify Cards, unassigned for third-party cards), there's currently no easy way to view the transactions from that card in Expensify. Admins are forced to scour the list of all credit card expenses to find them, which is an arduous, unnecessarily manual process.

Solution

Show closed cards on the card filter of the reports page. This would allow admins to filter for transactions on terminated Expensify Cards/unassigned company cards, allowing them to easily view/account for the transactions in one place. Only cards that have incurred transactions before being terminated/unassigned would appear in this section.

I'm thinking the easiest way to do this would be just to add a Closed cards section to the existing Card filter on the reports page, below the active cards. But interested to hear what @Expensify/design thinks.

cc @JmillsExpensify @mountiny

Issue Owner

Current Issue Owner: @waterim

[melvin-bot]

Triggered auto assignment to @alexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[joekaufmanexpensify]

I could also maybe see changing Individual cards to Active cards. I feel like that maybe makes a bit more sense if we're adding a Closed cards section. But not super passionate.

[joekaufmanexpensify]

@koko57 @waterim @narefyev91 @VickyStash any interest in this one?

[mountiny]

I can update the BE to return the closed state cards too but we need to make sure to not show them in the expensify cards feed page or in the Wallet as well - only in the filter (that needs to be done in fe)

[joekaufmanexpensify]

Makes sense. TY!

[JmillsExpensify]

Nice, thanks for putting this together!

[joekaufmanexpensify]

course!

[dubielzyk-expensify]

Yeah that sounds like the right call. Like this?

[waterim]

I can help with this one!

[dannymcclain]

Yeah that sounds like the right call. Like this?

This is pretty much exactly what I was thinking, but I do like Joe's suggestion of updating Individual cards to Active cards if we think that makes sense. Then we'd have All, Active, and Closed, which feels pretty good to me?

And another quick question—if you selected one of the All options, would it select both active and closed cards for that feed?

[joekaufmanexpensify]

I'd personally expect All to include all transactions on the card program for the selected period. Including active and closed cards.

Otherwise there'd be no way to easily view all transactions on the card program during a specific period without selecting all and then also selecting each closed card, which feels like odd UX to me.

[dannymcclain]

Agree with that!

[shawnborton]

Makes sense to me too 👍

[mountiny]

@waterim we are now also returning the Closed and Suspended cards to the App

[waterim]

Hey @mountiny I missed this ticket in my backlog, looking into that today, thank you for mentioning!

[waterim]

To be clear regarding the issue:

1. I need to rename Individual cards to Active cards
2. I need to add new section Closed cards

we are now also returning the Closed and Suspended cards to the App

3. Do I need also add Suspended cards? Or it should be combined with closed?
4. Add selection also for Clsoed

And regarding this:

I can update the BE to return the closed state cards too but we need to make sure to not show them in the expensify cards feed page or in the Wallet as well - only in the filter (that needs to be done in fe)

Do I need to filter out on expensify cards feed page and wallet page closed and suspended cards? (states 6 and 7)

@mountiny @joekaufmanexpensify

[waterim]

bump @mountiny @joekaufmanexpensify

[joekaufmanexpensify]

I need to rename Individual cards to Active cards
I need to add new section Closed cards

Do I need also add Suspended cards? Or it should be combined with closed?
Add selection also for Clsoed

Good Qs. Initially I was thinking Active cards and Closed cards cards made sense. But it's a good point on suspended cards. Those are not active right now, but could be in the future if the limit is raised above $0 again.

We should definitely show suspended cards to ensure any transactions on them incurred before they were suspended are visible. I think the most natural thing is to combine active and suspended cards in one section (because suspended are active cards that temporarily cannot be used) and then have closed in another section.

Active vs suspended feels like a nuance most customers won't care about, so I think it's prob fine to still go with active and closed as the two sections, but curious if others agree?

Do I need to filter out on expensify cards feed page and wallet page closed and suspended cards? (states 6 and 7)

I'd recommend we follow OldDot. There, we show suspended cards on the card feed and equivalent of the wallet page because cards being suspended is most commonly because the limit was just set to $0 (which can be changed). But we filter out closed cards.

Thoughts @mountiny @dannymcclain @shawnborton @dubielzyk-expensify

[dannymcclain]

That all sounds good to me.