[Due for payment 2025-02-19] [$250] Workspace -"Invited 1 user to Chat Report" displayed instead of WS name when inviting member

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.92-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5530917&group_by=cases:section_id&group_order=asc&group_id=229067
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Chat Report View

Action Performed:

Prerequisite: Have at least one room created for the workspace, so that an #Admins room is displayed.

1. Open the Expensify app.
2. Open any workspace chat.
3. Tap on workspace header and select "Members"
4. Invite new members to the workspace chat.
5. Return to LHN.
6. Check the message displayed on Admins room on LHN.
7. Open the Admins room and check the message displayed on chat.

Expected Result:

When inviting a new member to a workspace chat, system message displayed on Admins room, should show the workspace name.

Actual Result:

When inviting a new member to a workspace chat, system message on Admins room shows "1 user invited to Chat Report" instead of showing the workspace name.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6728147_1738208070290.Chat_Report.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021885267438744802218
• Upwork Job ID: 1885267438744802218
• Last Price Increase: 2025-01-31

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat Report is shown instead of the workspace name.

What is the root cause of that problem?

We build the message from the action originalMessage. The report name is taken from roomName and the roomName for policy expense chat is 'Chat Report'. It's the same as the policy expense chat reportName.

App/src/libs/SidebarUtils.ts

Lines 528 to 534 in 286a4cd

	const roomName = lastActionOriginalMessage?.roomName ?? '';
	if (roomName) {
	const preposition =
	lastAction.actionName === CONST.REPORT.ACTIONS.TYPE.ROOM_CHANGE_LOG.INVITE_TO_ROOM || lastAction.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.INVITE_TO_ROOM
	? ` ${translate(preferredLocale, 'workspace.invite.to')}`
	: ` ${translate(preferredLocale, 'workspace.invite.from')}`;
	result.alternateText += `${preposition} ${roomName}`;

App/src/libs/ReportActionsUtils.ts

Lines 1235 to 1248 in 286a4cd

	const roomName = originalMessage?.roomName;
	if (roomName) {
	const preposition = isInviteAction ? ` ${translateLocal('workspace.invite.to')} ` : ` ${translateLocal('workspace.invite.from')} `;
	if (originalMessage.reportID) {
	return [
	{
	kind: 'text',
	content: preposition,
	},
	{
	kind: 'roomReference',
	roomName,

What changes do you think we should make in order to solve the problem?

We can use getReportName to get the report name based on the logic inside getReportName.

const roomName = getReportName(allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${lastActionOriginalMessage?.reportID}`]);

This will also fix the case where the room name is updated.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021885267438744802218

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[hungvu193]

@bernhardoj 's proposal looks good to me
🎀👀🎀

[melvin-bot]

Triggered auto assignment to @amyevans, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[amyevans]

Sounds like a plan 👍

[bernhardoj]

PR is ready

cc: @hungvu193

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.96-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Chat Report is shown as the report name on the system message text #56298

If no regressions arise, payment will be issued on 2025-02-19. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests
• @bernhardoj requires payment through NewDot Manual Requests

[melvin-bot]

@hungvu193 @twisterdotcom @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]