Fix inline code doesn't accept bold and/or italic #55398

bernhardoj · 2025-01-17T14:15:13Z

Explanation of Change

Fixed Issues

$ #39623
PROPOSAL: #39623 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open any chat
Send an inline code text with a combination of bold and italic.

_`|||`_
*`|||`*
*_`|||`_*

Verify the markdown style is applied correctly

NOTE: This won't work on Hybrid App until https://github.com/Expensify/Mobile-Expensify/pull/13392 is merged

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-01-17T14:15:20Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dannymcclain · 2025-01-17T14:17:53Z

@bernhardoj would you mind adding some screenshots with actual text (instead of just pipes) so we can get a sense of what the new fonts will really look like?

bernhardoj · 2025-01-17T14:22:36Z

Here you go

Web:

Native:

dannymcclain · 2025-01-17T14:24:15Z

Nice, thanks! That's looking pretty darn good to me.

shawnborton · 2025-01-17T14:43:38Z

Same here!

hoangzinh · 2025-01-20T09:39:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-02.at.22.03.41.mov

Android: mWeb Chrome

Screen.Recording.2025-02-02.at.21.55.40.android.chrome.mov

iOS: Native

Screen.Recording.2025-02-02.at.22.12.27.mov

iOS: mWeb Safari

Screen.Recording.2025-02-02.at.21.58.24.ios.safari.mov

MacOS: Chrome / Safari

MacOS: Desktop

hoangzinh · 2025-01-20T10:14:34Z

ios/NewExpensify/Info.plist

+		<string>ExpensifyMono-BoldItalic.otf</string>
+		<string>ExpensifyMono-Italic.otf</string>


Is it possible to move those lines under this line

App/ios/NewExpensify/Info.plist

Line 95 in d2806ff

<string>ExpensifyMono-Regular.otf</string>

hoangzinh · 2025-01-21T10:51:56Z

ios/NewExpensify.xcodeproj/project.pbxproj

@@ -142,6 +144,7 @@
 		8B28D84EF339436DBD42A203 /* ExpensifyNeue-BoldItalic.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = "ExpensifyNeue-BoldItalic.otf"; path = "../assets/fonts/native/ExpensifyNeue-BoldItalic.otf"; sourceTree = "<group>"; };
 		8EFE0319D586C1078DB926FD /* Pods-NewExpensify.releaseadhoc.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-NewExpensify.releaseadhoc.xcconfig"; path = "Target Support Files/Pods-NewExpensify/Pods-NewExpensify.releaseadhoc.xcconfig"; sourceTree = "<group>"; };
 		9196A72C11B91A52A43D6E8A /* libPods-NotificationServiceExtension.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = "libPods-NotificationServiceExtension.a"; sourceTree = BUILT_PRODUCTS_DIR; };
+		A96F65C6624044318D21DAB1 /* ExpensifyMono-BoldItalic.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = undefined; includeInIndex = 0; lastKnownFileType = unknown; name = "ExpensifyMono-BoldItalic.otf"; path = "../assets/fonts/native/ExpensifyMono-BoldItalic.otf"; sourceTree = "<group>"; };


Could you explain why fileEncoding = undefined, isn't it fileEncoding = 9

Idk, it's auto generated 😅

If we see this PR #13714 which added fonts too, the fileEncoding is also undefined. This PR #16540 is the one that updates it to 9.

It looks like the script is outdated. #16540 was 2 years ago, then we might need to do same for this PR. What do you think?

I've updated it to make it consistent with other fonts. ChatGPT said that 9 means the encoding is UTF-16. (4 is UTF-8)

hoangzinh · 2025-01-21T10:52:50Z

ios/NewExpensify.xcodeproj/project.pbxproj

@@ -159,6 +162,7 @@
 		E9DF872C2525201700607FDC /* AirshipConfig.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = AirshipConfig.plist; sourceTree = "<group>"; };
 		ED297162215061F000B7C4FE /* JavaScriptCore.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = JavaScriptCore.framework; path = System/Library/Frameworks/JavaScriptCore.framework; sourceTree = SDKROOT; };
 		ED2971642150620600B7C4FE /* JavaScriptCore.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = JavaScriptCore.framework; path = Platforms/AppleTVOS.platform/Developer/SDKs/AppleTVOS12.0.sdk/System/Library/Frameworks/JavaScriptCore.framework; sourceTree = DEVELOPER_DIR; };
+		ED64768FC6254E4D8FCD12BC /* ExpensifyMono-Italic.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = undefined; includeInIndex = 0; lastKnownFileType = unknown; name = "ExpensifyMono-Italic.otf"; path = "../assets/fonts/native/ExpensifyMono-Italic.otf"; sourceTree = "<group>"; };


Same here fileEncoding = undefined

Same as above

hoangzinh · 2025-01-22T08:25:15Z

Bug 1: Inline code doesn't accept bold in IOS

Screen.Recording.2025-01-22.at.15.22.10.mov

bernhardoj · 2025-01-23T02:43:47Z

Hmm, I did retest when updating the Info.plist, but not when updating the fileEncoding. Maybe it causes a problem. I will retest first.

bernhardoj · 2025-01-23T06:59:46Z

Hmm, everything still works fine on my end. From your video, the sent message doesn't have the style markdown too.

Are you sure you have rebuild the app?

hoangzinh · 2025-01-23T09:16:31Z

I found out, it doesn't work for IOS hybrid app

Screen.Recording.2025-01-23.at.16.13.33.mov

bernhardoj · 2025-01-23T11:39:45Z

I see. This is hard since I don't have access to the hybrid app. Maybe the font asset needs to be added to the hybrid codebase too? Btw, does it works fine on android hybrid?

hoangzinh · 2025-01-23T12:51:07Z

Btw, does it works fine on android hybrid?

Same issue on android hybrid. No worries, I can help you to configure those new fonts on the hybrid repo. @bernhardoj

hoangzinh · 2025-01-23T12:52:03Z

cc @NikkiWines Sorry for mentioning you earlier, it seems I have to help @bernhardoj on the hybrid repo.

bernhardoj · 2025-01-24T05:19:08Z

@hoangzinh thanks a lot!

hoangzinh · 2025-01-24T14:47:58Z

Quick updates: I tried to follow this guidelines, and got error

npm error could not determine executable to run

when ran command npx @react-native-community/cli-link-assets

bernhardoj · 2025-01-24T17:45:27Z

Ah, I did encounter that too. I use https://github.com/callstack/react-native-asset instead.

hoangzinh · 2025-01-29T12:49:10Z

Quick updates: I created a PR here for Hybrid app. I'm getting an error when building for Android hybrid app. I will try to fix it and complete the PR checklist soon

hoangzinh · 2025-02-01T00:52:18Z

Hi @bernhardoj, @NikkiWines and I had a discussion in the PR of hybrid app and we think we should merge your PR first, otherwise, it will cause build failure for Hybrid apps. Can you help to add a note in the "QA steps" to let them know that it won't work for Hybrid app until this PR https://github.com/Expensify/Mobile-Expensify/pull/13392 is merged?

bernhardoj · 2025-02-01T04:06:29Z

@hoangzinh I see. Merged with main and added the note.

hoangzinh

LGTM

NikkiWines

@bernhardoj maybe merge main again to see if that fixes the jest failure 🙏

bernhardoj · 2025-02-04T03:28:24Z

@NikkiWines done

NikkiWines

OSBotify · 2025-02-04T17:25:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-06T22:01:07Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.0.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

kavimuru · 2025-02-07T02:52:45Z

iOS failing with original bug id #39623

https://platform.applause.com/services/links/v1/external/d986730c14d4a4e5ad56ab221317e059dbc2cd086bf87eb279d28a9059708161

bernhardoj added 2 commits January 17, 2025 22:11

add mono bold and bolditalic font

068bacf

fix inline code doesn't accept custom font

eb921a4

bernhardoj requested review from a team as code owners January 17, 2025 14:15

melvin-bot bot requested review from hoangzinh and removed request for a team January 17, 2025 14:15

fix live markdown inline code can't accept font style

d2806ff

hoangzinh reviewed Jan 20, 2025

View reviewed changes

reposition

a9f8000

hoangzinh reviewed Jan 21, 2025

View reviewed changes

update fileencoding

1d9838d

Merge branch 'main' into fix/39623-inline-code-font

a785968

hoangzinh approved these changes Feb 2, 2025

View reviewed changes

melvin-bot bot requested a review from NikkiWines February 2, 2025 15:14

NikkiWines reviewed Feb 3, 2025

View reviewed changes

Merge branch 'main' into fix/39623-inline-code-font

b5b3a82

NikkiWines approved these changes Feb 4, 2025

View reviewed changes

NikkiWines merged commit 08358b5 into Expensify:main Feb 4, 2025
17 checks passed

github-actions bot mentioned this pull request Feb 6, 2025

Deploy Checklist: New Expensify 2025-02-06 #56482

Open

		<string>ExpensifyMono-BoldItalic.otf</string>
		<string>ExpensifyMono-Italic.otf</string>

Fix inline code doesn't accept bold and/or italic #55398

Fix inline code doesn't accept bold and/or italic #55398

Conversation

bernhardoj commented Jan 17, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 17, 2025

dannymcclain commented Jan 17, 2025

bernhardoj commented Jan 17, 2025

dannymcclain commented Jan 17, 2025

shawnborton commented Jan 17, 2025

hoangzinh commented Jan 20, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hoangzinh commented Jan 22, 2025

bernhardoj commented Jan 23, 2025

bernhardoj commented Jan 23, 2025

hoangzinh commented Jan 23, 2025

bernhardoj commented Jan 23, 2025

hoangzinh commented Jan 23, 2025

hoangzinh commented Jan 23, 2025

bernhardoj commented Jan 24, 2025

hoangzinh commented Jan 24, 2025

bernhardoj commented Jan 24, 2025

hoangzinh commented Jan 29, 2025

hoangzinh commented Feb 1, 2025

bernhardoj commented Feb 1, 2025

hoangzinh left a comment

Choose a reason for hiding this comment

NikkiWines left a comment

Choose a reason for hiding this comment

bernhardoj commented Feb 4, 2025

NikkiWines left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 4, 2025

github-actions bot commented Feb 6, 2025

kavimuru commented Feb 7, 2025

bernhardoj commented Jan 17, 2025 •

edited

Loading

hoangzinh commented Jan 20, 2025 •

edited

Loading