[HOLD for payment 2025-02-06] [$250] Reports - Expense report page is closed after the payment is cancelled

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.82-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5426746&group_by=cases:section_id&group_order=asc&group_id=296775
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Money Requests

Action Performed:

1. Open the staging.new.expensify.com website.
2. Tap on "Reports" on the bottom of the screen.
3. Open any expense on the list.
4. Tap on "Pay Elsewhere" button.
5. Tap on report header.
6. Tap on "Cancel Payment"
7. Confirm the action on the modal displayed.

Expected Result:

After the expense payment is cancelled, the user should remain on the expense report.

Actual Result:

Expense report is closed and the user lands on expenses list again after the expense payment is cancelled.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021878887212575034772
• Upwork Job ID: 1878887212575034772
• Last Price Increase: 2025-01-13
• Automatic offers:
• DylanDylann | Reviewer | 105710532
• twilight2294 | Contributor | 105710535

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[twilight2294]

Edited by proposal-police: This proposal was edited at 2025-01-09 18:09:21 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense report page is closed after the payment is cancelled

What is the root cause of that problem?

We dismiss the model hence the whole report gets dismissed:

App/src/libs/actions/IOU.ts

Line 8002 in e09c8ab

Navigation.dismissModal();

When we open a report through the expense reports page, it is considered an RHP as a whole, hence on calling Navigation.dismissModal() , the entire RHP gets dismissed than going back

What changes do you think we should make in order to solve the problem?

we should instead use Navigation.goBack();, this will make sure that we will always go back to the report page,

Note that we can also pass backTo param from the URL to goBack function, as if we refresh the screen the navigation stack is wiped away.

In ReportDetailsPage here:

App/src/pages/ReportDetailsPage.tsx

Line 317 in e09c8ab

IOU.cancelPayment(moneyRequestReport, chatReport);

        IOU.cancelPayment(moneyRequestReport, chatReport, backTo);

And then in IOU.ts here:

App/src/libs/actions/IOU.ts

Line 8002 in e09c8ab

Navigation.dismissModal();

    Navigation.goBack(backTo);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

We can alternatively only use Navigation.goBack() for reports opened through the expense reports page and keep calling Navigation.dismissModal() for regular full page reports. this can be done by checking if have a backTo param in the URL. but i guess the first method would be appropriate for both the cases

[melvin-bot]

@zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021878887212575034772

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[zanyrenney]

@DylanDylann please could you review the proposal above when you get a minute., thanks!

[DylanDylann]

@twilight2294's proposal looks good to me

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MonilBhavsar]

Looks good

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @twilight2294 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[twilight2294]

Will make a PR later today

[melvin-bot]

@MonilBhavsar, @zanyrenney, @DylanDylann, @twilight2294 Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.91-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• update navigation from dismiss modal to goBack #55479

If no regressions arise, payment will be issued on 2025-02-06. 🎊

For reference, here are some details about the assignees on this issue:

• @DylanDylann requires payment automatic offer (Reviewer)
• @twilight2294 requires payment automatic offer (Contributor)

[melvin-bot]

@DylanDylann @zanyrenney @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[zanyrenney]

@DylanDylann please complete the checklist and ping me when you have so i can complete the payout - thanks!

[DylanDylann]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: 8ff9230#r152258433

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Prerequisite

• There is a unpaid expense

Test:

1. Tap on "Reports" on the bottom of the screen.
2. Open any expense on the list.
3. Tap on "Pay Elsewhere" button. > Tap on report header > Tap on "Cancel Payment"> Confirm the action on the modal displayed.

Do we agree 👍 or 👎