[$250] Wallet - "Street cannot be left blank" error when all the address fields are manually entered

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.79-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0
App Component: Other

Action Performed:

Precondition:

• Personal details are not filled.
• User has assigned themselves a physical card.

1. Go to staging.new.expensify.com
2. Go to Wallet.
3. Click on the physical card.
4. Click Get physical card.
5. Enter name and phone number > Next.
6. On address page, manually fill in the address instead of selecting an address from the suggestion dropdown.
7. Proceed to confirmation page.
8. Enter magic code.

Expected Result:

User should be able to validate the information since all the address fields are filled.

Actual Result:

"Street cannot be left blank" error shows up when all the address fields are manually filled.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6702829_1735290006251.20241227_165355.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021874901847923118933
• Upwork Job ID: 1874901847923118933
• Last Price Increase: 2025-01-02
• Automatic offers:
• DylanDylann | Reviewer | 105846098
• daledah | Contributor | 105846099

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @daledah

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[garrettmknight]

Closing to handle regression here.

[sakluger]

I'm reopening this because I think it's unrelated to the linked issue above (@chiragsalian confirmed that they appear to be unrelated in Slack).

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021874901847923118933

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[DylanDylann]

This error message "Street cannot be left blank" comes from BE

Screen.Recording.2025-01-04.at.05.19.16.mov

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[DylanDylann]

@srikarparsi Could you help to check why the BE returned this error message? I see the payload sent from FE looks fine

[srikarparsi]

Hi yes, I'll make some time out for this tomorrow

[srikarparsi]

Is this still reproducible for you @DylanDylann? I'm now getting this error (which is still a problem), but it's past the Street cannot be left blank throw in the backend

[DylanDylann]

@srikarparsi I already tried again and saw the same error message: "Street cannot be left blank" even when I entered the correct magic code

Screen.Recording.2025-01-07.at.13.07.01.mov

But I see the error message is from BE. This is the payload from FE, could you help to check if we have any mismatch between FE and BE?

[melvin-bot]

@sakluger @srikarparsi @DylanDylann this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mountiny]

@daledah what is your ETA?

[daledah]

Will open PR today or tomorrow

[allgandalf]

@daledah what's the status, we are holding #54041 (this is a #quality issue so kind of high priority) for this issue, if you're low on availability let us know 😄

[daledah]

The PR is a bit long. I will try to open PR soon.

[DylanDylann]

@daledah If there is any problem while implementing PR, feel free to raise it with me and we can solve it together

[allgandalf]

@daledah any ETA?

[daledah]

@mountiny Looks like SetPersonalDetailsAndShipExpensifyCards requires dob, but Get Physical Card form doesn't have this input yet.

What should we handle in this situation? A fix from BE or add another DOB input to Get Physical Card form?

[DylanDylann]

Oops, It seems we made a mistake here. To correct, we need to use src/pages/MissingPersonalDetails folder and remove src/pages/settings/Wallet/Card

[daledah]

@DylanDylann Yes, that makes more sense to me after I bumped into the bug asked above. I'll try to open PR later today.

[mountiny]

LEts use what is in the SetPersonalDetailsAndShipExpensifyCards now

[daledah]

@DylanDylann we have a open PR here

[DylanDylann]

@mountiny @joekaufmanexpensify Should we hide the "Get physical card" after users add their private personal details? If we don't want to hide it, what screen should be displayed if users click on it?

Currently, the confirmation page will be displayed even after the personal details already been added

Screen.Recording.2025-02-05.at.14.41.49.mov

[joekaufmanexpensify]

Hmm, do you mean automatically ship a physical card to your address from your private personal details (if they're completed) when you're assigned a personal card?

[mountiny]

I think it would be nice to explore sending the cards automatically, but I would follow up on that later maybe.

I think for now we just let them to confirm the details to ship the card. So the buttons should say something more in the vein of "confirm shipping details" and then "Ship the card" in the form itself

[joekaufmanexpensify]

Agreed. I am less sure we should even ship physical cards automatically at all. Feels plausible someone could have a shipping address different from their personal address in private personal details, and not sure we want to assume they are the same and just ship.

[mountiny]

Very fair, although the form does just update your private personal details :D so if we want to keep these separate it is different concern

[joekaufmanexpensify]

Ah, okay. Even if it updates the personal details though, my 2c is it's nice for the user to confirm where the card is going, rather than just automatically shipping it.

[mountiny]

I agree!

@DylanDylann @daledah could you please share screenshots of how it looks like now so then the marketting team can help with the copy?

[DylanDylann]

@mountiny The screenshot here

[DylanDylann]

so if we want to keep these separate it is different concern

Earlier I thought we would handle it separately 😄