Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection gets removed after navigating to a single per diem option #54498

Open
1 of 8 tasks
mitarachim opened this issue Dec 24, 2024 · 27 comments
Open
1 of 8 tasks

Selection gets removed after navigating to a single per diem option #54498

mitarachim opened this issue Dec 24, 2024 · 27 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@mitarachim
Copy link

mitarachim commented Dec 24, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.78-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Windows 11 pro/chrome
App Component: Workspace Settings

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Create a workspace
  3. Enable per diem
  4. Import a spreadsheet for per diem
  5. Select all
  6. Click on one of the per diem rates

Expected Result:

Selection doesn't reset. (App works consistently with the categories page)

Actual Result:

Selection resets

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6701567_1735002522319.bandicam_2024-12-24_04-05-50-424.mp4

View all open jobs on GitHub

@mitarachim mitarachim added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 24, 2024
Copy link

melvin-bot bot commented Dec 24, 2024

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Dec 24, 2024

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Dec 24, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 24, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@NJ-2020
Copy link
Contributor

NJ-2020 commented Dec 24, 2024

I think this could be NAB because in this issue we're only fixing for categories page only

If we want to fix inside the per-diem page also, we can do the same as we do for categories page

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Dec 24, 2024

@truph01 Care to take on this issue as well?

@jasperhuangg jasperhuangg added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 24, 2024
@truph01
Copy link
Contributor

truph01 commented Dec 25, 2024

Care to take on this issue as well?

Yes. I can work on it

@Christinadobrzyn
Copy link
Contributor

Thanks @truph01 I assigned you to this issue

Copy link

melvin-bot bot commented Dec 31, 2024

@grgia, @Christinadobrzyn, @truph01 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Dec 31, 2024
@garrettmknight garrettmknight moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Dec 31, 2024
Copy link

melvin-bot bot commented Jan 2, 2025

@grgia, @Christinadobrzyn, @truph01 Huh... This is 4 days overdue. Who can take care of this?

@grgia
Copy link
Contributor

grgia commented Jan 2, 2025

@truph01 any updates on this one?

@truph01
Copy link
Contributor

truph01 commented Jan 2, 2025

@truph01 any updates on this one?

I have a question for the internal team, which I’ve asked here. I’ll provide an update on the next steps once they respond.

@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2025
Copy link

melvin-bot bot commented Jan 6, 2025

@grgia, @Christinadobrzyn, @truph01 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Jan 6, 2025
Copy link

melvin-bot bot commented Jan 7, 2025

@grgia @Christinadobrzyn @truph01 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@Christinadobrzyn
Copy link
Contributor

Looks like we're still waiting on an answer to these questions #49322 (comment)

Is that accurate @truph01?

@truph01
Copy link
Contributor

truph01 commented Jan 7, 2025

Is that accurate @truph01?

Yes

@melvin-bot melvin-bot bot removed the Overdue label Jan 7, 2025
@Christinadobrzyn
Copy link
Contributor

Oh perfect thank you @truph01! It looks like @MonilBhavsar gave a 👍 to move forward with your proposal.

Sorry, can you let us know how that will affect this issue? Should we put it on hold for now?

@truph01
Copy link
Contributor

truph01 commented Jan 9, 2025

Should we put it on hold for now

Yes, we should put it on hold for now

@grgia
Copy link
Contributor

grgia commented Jan 9, 2025

@truph01 what issue is this held on?

@melvin-bot melvin-bot bot added the Overdue label Jan 13, 2025
Copy link

melvin-bot bot commented Jan 13, 2025

@grgia, @Christinadobrzyn, @truph01 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@truph01
Copy link
Contributor

truph01 commented Jan 13, 2025

This issue needs to be held on #49322

@melvin-bot melvin-bot bot removed the Overdue label Jan 13, 2025
@Christinadobrzyn Christinadobrzyn changed the title Selection gets removed after navigating to a single per diem option [HOLD for 49322] Selection gets removed after navigating to a single per diem option Jan 13, 2025
@grgia grgia added Weekly KSv2 and removed Daily KSv2 labels Jan 14, 2025
@garrettmknight garrettmknight added the Internal Requires API changes or must be handled by Expensify staff label Jan 14, 2025
@Christinadobrzyn
Copy link
Contributor

monitoring - #49322

1 similar comment
@Christinadobrzyn
Copy link
Contributor

monitoring - #49322

@grgia
Copy link
Contributor

grgia commented Jan 24, 2025

linked issue still in progress

@Christinadobrzyn
Copy link
Contributor

monitoring - #49322

1 similar comment
@Christinadobrzyn
Copy link
Contributor

monitoring - #49322

@truph01
Copy link
Contributor

truph01 commented Feb 11, 2025

PR is ready since the related PR is already merged.

@MonilBhavsar MonilBhavsar changed the title [HOLD for 49322] Selection gets removed after navigating to a single per diem option Selection gets removed after navigating to a single per diem option Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
Status: Bugs and Follow Up Issues
Development

No branches or pull requests

7 participants