[$1000] Chat - Most of the workspace modifying settings messages are not translated in #Admins

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.66-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #52159

Action Performed:

Setup: Login on ND with a user that has a workspace where some settings have been changed (for instance, currency, reporting frequency, approval mode, approver)

1. At the bottom of the screen, go to "Settings"
2. Click on "Preferences"
3. Click on "Language" and select "Spanish"
4. Go to the "#Admins" room

Expected Result:

All workspace modifying settings messages are translated.
For instance:
SP: actualizó la moneda por defecto de ARS - AR$ a USD - $
EN: updated the default currency from ARS - AR$ to USD - $

Actual Result:

Most of the workspace modifying settings messages are not translated

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021861045305847069497
• Upwork Job ID: 1861045305847069497
• Last Price Increase: 2025-01-21
• Automatic offers:
• Krishna2323 | Contributor | 105059490

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Shahidullah-Muffakir]

We are getting these message from the api response.

[jliexpensify]

Hi @rushatgabhane @techievivek - assigning you for review as you worked on #52159.

[techievivek]

@Krishna2323 would you be interested in working on this one as well? Can you take a look at the GH?

[Krishna2323]

@techievivek yeah I would like to work on this, checking...

[Krishna2323]

@techievivek, since these messages are coming from the backend, we would need to check the action type and create util functions to return the message with correct translations, like we are doing with several other workspace actions. We would also need to do similar thing in ContextMenuActions & SidebarUtils. There are several other actions which are not covered yet, like category removal/addition. More can be discussed in the PR.

App/src/pages/home/report/ReportActionItem.tsx

Lines 705 to 713 in 2b4ff21

	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_NAME) {
	children = <ReportActionItemBasicMessage message={ReportUtils.getWorkspaceNameUpdatedMessage(action)} />;
	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.ADD_EMPLOYEE) {
	children = <ReportActionItemBasicMessage message={ReportActionsUtils.getPolicyChangeLogAddEmployeeMessage(action)} />;
	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_EMPLOYEE) {
	children = <ReportActionItemBasicMessage message={ReportActionsUtils.getPolicyChangeLogChangeRoleMessage(action)} />;
	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.DELETE_EMPLOYEE) {
	children = <ReportActionItemBasicMessage message={ReportActionsUtils.getPolicyChangeLogDeleteMemberMessage(action)} />;
	} else if (ReportActionsUtils.isActionOfType(action, CONST.REPORT.ACTIONS.TYPE.REMOVED_FROM_APPROVAL_CHAIN)) {

[techievivek]

Sounds good to me.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021861045305847069497

[melvin-bot]

Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Krishna2323]

Will start working on this tomorrow 🙇🏻

[techievivek]

Not overdue, PR is being worked upon.

[techievivek]

Not overdue, PR is being worked on.

[Krishna2323]

Update: Actively working on a PR, but progress is a bit slow. Yesterday, even after spending few hours I only managed to add two translations and refactored some code to improve readability.

[stephanieelliott]

Hey @Krishna2323, I have an issue where the default workspace name is not being translated when Spanish language is selected (i.e. My Group Workspace should be Mi Espacio de Trabajo en Grupo). I know you are working on a handful of WS translations here -- will the workspace name be addressed in your PR, or should we handle that separately? #53599

[Krishna2323]

@stephanieelliott, that should be solved as a separate issue because the initial workspace name is generated on the frontend and here we are working on adding translations for the setting messages received from the backend.

[Krishna2323]

UPDATE: Total 14 translations has been added till now.

[jliexpensify]

I'm OOO until the 29th, feel free to reassign if payment is needed before then - otherwise will catch up when I get back.

[melvin-bot]

@rushatgabhane @jliexpensify @techievivek @Krishna2323 this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[jliexpensify]

@Krishna2323 you're still working on this right?

[Krishna2323]

@jliexpensify, yes. Sorry for delay, I'm on holidays, I'll be back on 4th jan and provide updates on the progress.

[Krishna2323]

I'm back from holidays, will continue to work on this from tomorrow.

[Krishna2323]

UPDATE: 3 more translations has been added.

@techievivek, could we split this update into two parts? This task has already required significant effort and time. Splitting it would make it easier for C+ and me, as there are many translations to verify. So far, 17 translations have been added, and I plan to increase that to 25 in this PR, with the remaining translations in the next PR.

I kindly request an increase in the bounty to $1000 for all 55+ translations, as this task has been particularly demanding and will require additional time to complete. Typically, I’ve noticed a regular $250 bounty for each translation. #46219

[Krishna2323]

UPDATE: A total of 23 translations have been added in the current PR so far, with around 35 still remaining.

ADD_APPROVER_RULE: 'POLICYCHANGELOG_ADD_APPROVER_RULE — ',
ADD_BUDGET: 'POLICYCHANGELOG_ADD_BUDGET — ',
ADD_CATEGORY: 'POLICYCHANGELOG_ADD_CATEGORY — ✅',
ADD_CUSTOM_UNIT: 'POLICYCHANGELOG_ADD_CUSTOM_UNIT — ',
ADD_CUSTOM_UNIT_RATE: 'POLICYCHANGELOG_ADD_CUSTOM_UNIT_RATE — ✅',
ADD_EMPLOYEE: 'POLICYCHANGELOG_ADD_EMPLOYEE — ✅',
ADD_INTEGRATION: 'POLICYCHANGELOG_ADD_INTEGRATION — ',
ADD_REPORT_FIELD: 'POLICYCHANGELOG_ADD_REPORT_FIELD — ✅',
ADD_TAG: 'POLICYCHANGELOG_ADD_TAG — ✅',
DELETE_ALL_TAGS: 'POLICYCHANGELOG_DELETE_ALL_TAGS — ',
DELETE_APPROVER_RULE: 'POLICYCHANGELOG_DELETE_APPROVER_RULE — ',
DELETE_BUDGET: 'POLICYCHANGELOG_DELETE_BUDGET — ',
DELETE_CATEGORY: 'POLICYCHANGELOG_DELETE_CATEGORY — ✅',
DELETE_CUSTOM_UNIT: 'POLICYCHANGELOG_DELETE_CUSTOM_UNIT — ',
DELETE_CUSTOM_UNIT_RATE: 'POLICYCHANGELOG_DELETE_CUSTOM_UNIT_RATE — ✅',
DELETE_CUSTOM_UNIT_SUB_RATE: 'POLICYCHANGELOG_DELETE_CUSTOM_UNIT_SUB_RATE — ',
DELETE_EMPLOYEE: 'POLICYCHANGELOG_DELETE_EMPLOYEE — ✅',
DELETE_INTEGRATION: 'POLICYCHANGELOG_DELETE_INTEGRATION — ✅',
DELETE_REPORT_FIELD: 'POLICYCHANGELOG_DELETE_REPORT_FIELD —  ✅',
DELETE_TAG: 'POLICYCHANGELOG_DELETE_TAG — ✅',
IMPORT_CUSTOM_UNIT_RATES: 'POLICYCHANGELOG_IMPORT_CUSTOM_UNIT_RATES — ',
IMPORT_TAGS: 'POLICYCHANGELOG_IMPORT_TAGS — ',
INDIVIDUAL_BUDGET_NOTIFICATION: 'POLICYCHANGELOG_INDIVIDUAL_BUDGET_NOTIFICATION — ',
INVITE_TO_ROOM: 'POLICYCHANGELOG_INVITETOROOM — ',
REMOVE_FROM_ROOM: 'POLICYCHANGELOG_REMOVEFROMROOM — ',
LEAVE_ROOM: 'POLICYCHANGELOG_LEAVEROOM — ',
REPLACE_CATEGORIES: 'POLICYCHANGELOG_REPLACE_CATEGORIES — ',
SET_AUTO_REIMBURSEMENT: 'POLICYCHANGELOG_SET_AUTOREIMBURSEMENT — ',
SET_AUTO_JOIN: 'POLICYCHANGELOG_SET_AUTO_JOIN — ',
SET_CATEGORY_NAME: 'POLICYCHANGELOG_SET_CATEGORY_NAME — ✅',
SHARED_BUDGET_NOTIFICATION: 'POLICYCHANGELOG_SHARED_BUDGET_NOTIFICATION — ',
UPDATE_ACH_ACCOUNT: 'POLICYCHANGELOG_UPDATE_ACH_ACCOUNT — ',
UPDATE_APPROVER_RULE: 'POLICYCHANGELOG_UPDATE_APPROVER_RULE — ',
UPDATE_AUDIT_RATE: 'POLICYCHANGELOG_UPDATE_AUDIT_RATE — ',
UPDATE_AUTO_HARVESTING: 'POLICYCHANGELOG_UPDATE_AUTOHARVESTING — ',
UPDATE_AUTO_REIMBURSEMENT: 'POLICYCHANGELOG_UPDATE_AUTOREIMBURSEMENT — ',
UPDATE_AUTO_REPORTING_FREQUENCY: 'POLICYCHANGELOG_UPDATE_AUTOREPORTING_FREQUENCY — ✅',
UPDATE_BUDGET: 'POLICYCHANGELOG_UPDATE_BUDGET — ',
UPDATE_CATEGORY: 'POLICYCHANGELOG_UPDATE_CATEGORY — ✅',
UPDATE_CATEGORIES: 'POLICYCHANGELOG_UPDATE_CATEGORIES — ',
UPDATE_CURRENCY: 'POLICYCHANGELOG_UPDATE_CURRENCY — ✅',
UPDATE_CUSTOM_UNIT: 'POLICYCHANGELOG_UPDATE_CUSTOM_UNIT — ',
UPDATE_CUSTOM_UNIT_RATE: 'POLICYCHANGELOG_UPDATE_CUSTOM_UNIT_RATE — ',
UPDATE_CUSTOM_UNIT_SUB_RATE: 'POLICYCHANGELOG_UPDATE_CUSTOM_UNIT_SUB_RATE — ',
UPDATE_DEFAULT_BILLABLE: 'POLICYCHANGELOG_UPDATE_DEFAULT_BILLABLE — ✅',
UPDATE_DEFAULT_REIMBURSABLE: 'POLICYCHANGELOG_UPDATE_DEFAULT_REIMBURSABLE — ',
UPDATE_DEFAULT_TITLE: 'POLICYCHANGELOG_UPDATE_DEFAULT_TITLE — ✅',
UPDATE_DEFAULT_TITLE_ENFORCED: 'POLICYCHANGELOG_UPDATE_DEFAULT_TITLE_ENFORCED — ✅',
UPDATE_DISABLED_FIELDS: 'POLICYCHANGELOG_UPDATE_DISABLED_FIELDS — ',
UPDATE_EMPLOYEE: 'POLICYCHANGELOG_UPDATE_EMPLOYEE — ✅',
UPDATE_FIELD: 'POLICYCHANGELOG_UPDATE_FIELD — APPROVAL_MODE ✅🟡 PREVENT_SELF_APPROVAL ✅ MAX_EXPENSE_AGE ✅',
UPDATE_MANUAL_APPROVAL_THRESHOLD: 'POLICYCHANGELOG_UPDATE_MANUAL_APPROVAL_THRESHOLD — ',
UPDATE_MAX_EXPENSE_AMOUNT: 'POLICYCHANGELOG_UPDATE_MAX_EXPENSE_AMOUNT — ✅',
UPDATE_MAX_EXPENSE_AMOUNT_NO_RECEIPT: 'POLICYCHANGELOG_UPDATE_MAX_EXPENSE_AMOUNT_NO_RECEIPT — ✅',
UPDATE_NAME: 'POLICYCHANGELOG_UPDATE_NAME — ✅',
UPDATE_DESCRIPTION: 'POLICYCHANGELOG_UPDATE_DESCRIPTION — ✅',
UPDATE_OWNERSHIP: 'POLICYCHANGELOG_UPDATE_OWNERSHIP — ',
UPDATE_REIMBURSEMENT_CHOICE: 'POLICYCHANGELOG_UPDATE_REIMBURSEMENT_CHOICE — ',
UPDATE_REPORT_FIELD: 'POLICYCHANGELOG_UPDATE_REPORT_FIELD — ' ✅,
UPDATE_TAG: 'POLICYCHANGELOG_UPDATE_TAG — ✅🟡',
UPDATE_TAG_ENABLED: 'POLICYCHANGELOG_UPDATE_TAG_ENABLED — ✅',
UPDATE_TAG_LIST: 'POLICYCHANGELOG_UPDATE_TAG_LIST — ',
UPDATE_TAG_LIST_NAME: 'POLICYCHANGELOG_UPDATE_TAG_LIST_NAME — ',
UPDATE_TAG_NAME: 'POLICYCHANGELOG_UPDATE_TAG_NAME — ✅',
UPDATE_TIME_ENABLED: 'POLICYCHANGELOG_UPDATE_TIME_ENABLED — ',
UPDATE_TIME_RATE: 'POLICYCHANGELOG_UPDATE_TIME_RATE — ',

[Krishna2323]

@jliexpensify @techievivek, please take a look at this comment when you get a chance. Thanks

@rushatgabhane, I would love to hear your opinion as well. :)

[jliexpensify]

Re: pricing, I think that's reasonable.

Re: splitting, I think let's defer to @techievivek (I'm not an Engineer so I'm unsure how to best manage this)

[techievivek]

Yeah, agree with both the suggestions. Let's push 2 PRs here.

[Krishna2323]

@rushatgabhane, you can start reviewing the PR. Half of the translations have been added, and I will ask for translation verification on Slack today. However, I'm not sure what should be included in the tests for the PR checklist. Please let me know if you have any suggestions.

[melvin-bot]

Upwork job price has been updated to $1000

[jliexpensify]

I've increased the bounty to $1000 cc @techievivek @rushatgabhane

[rushatgabhane]

@Krishna2323 could you please link the PR? I can't find it

[Krishna2323]

@rushatgabhane the PR.

[techievivek]

How is PR going here? @Krishna2323, do you need help with anything, please let me know if you do.

[Krishna2323]

PR is almost ready, there are some conflicts remaining and I'll resolve those today and it can be reviewed then.