-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Give users on a domain the ability to join their colleagues when the company is already using Expensify #48189
Comments
Current assignee @dubielzyk-expensify is eligible for the Design assigner, not assigning anyone new. |
Looks solid to me! |
How does this look on desktop? |
Same!
Also curious 🙃 👀 |
I like the full width version, personally! ❤️ |
Yeah, the full width does look nice. Thanks for the desktop mocks, they check out nicely ✅ |
Agree! Stretch it baby! Desktop mocks looking good. 🫶 |
The jury has spoken. Final Figma files can be found here: https://www.figma.com/design/ir27daDKHaB1g4iZCT22K5/Onboarding-v2?node-id=7147-9183 |
@trjExpensify - can this be built by the contributor or do we need BE code? Curious for a second set of eyes. Asking you as you wrote down the steps in the solution |
I think this is mostly FE, but we might need some BE work for the "Select a workspace" page to get that list of accessibleDomainPolicies - I'm not quite sure if we have that available to NewDot. @luacmartins & @mountiny we built the request to join stuff in simplified collect with the |
AFAIK we don't have this data in NewDot yet, so we'd need to fetch it when we open that page. |
Kewl, so we do need BE here then yes? |
yes |
Yeah, agreed we will need to fetch that; also, somehow, indicate which one is "Join now" and which one is "Ask to join". couple questions:
|
Join now = workspace doesn't require approval to join That's the distinction between the two buttons, so I assume that's something on the policy object we store for use with policy join links. As for what happens when you click them, that's outlined in the OP in step 5. Let me know if you have any qs on that!
If we're mirroring the Inbox on OldDot, they don't. So maybe "Skip" is better than "Skip for now" which implies you can get back to it. We could look at something on the workspaces page with a list of available workspaces to join instead of the empty state when applicable, but I'm also fine to descope that to start and keep it to this one-time onboarding modal flow. |
I have clarified the exact workspace setting in the original description! |
@parasharrajat, @allroundexperts, @isabelastisser, @marcaaron 12 days overdue. Walking. Toward. The. Light... |
In progress. Waiting on some updates from internal team. |
@allroundexperts - where did we land on this question? Going to assign you @flodnv so we can see this last bit through. |
@allroundexperts What's new here? |
@flodnv, @parasharrajat, @allroundexperts, @isabelastisser, @marcaaron Eep! 4 days overdue now. Issues have feelings too... |
@flodnv, @parasharrajat, @allroundexperts, @isabelastisser, @marcaaron Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@allroundexperts, can you please provide an update? Thanks! |
@flodnv Are your changes deployed? |
As of 1 hour ago, yes they're in production! |
What is next here? @allroundexperts @flodnv. I don't have access to that Slack thread, so I can't tell what's happening in the background. |
I am done making the API that was blocking the issue. I don't know what else remains, @allroundexperts ? |
It's on me now. I'll try to add screen recordings tomorrow. |
Please tag me to the PR. |
Here's the draft PR @parasharrajat |
Proposal: Allow a private domain sign up, whose company is already using Expensify to request to join relevant workspace(s)
Problem: One of the cool things about Expensify is that anyone can sign up without their company's permission or invitation. But this means when an employee signs up independently they are not aware their company is already using Expensify and so end up creating their own workspaces in error, causing a lot of confusion for themselves and their company
Solution: Mirror Classic when it comes to an employee that signs up with a private domain email of a company that already has one or more workspaces. It goes like this:
Ask to join
orJoin
based on the workspace JSON'sautomaticJoiningEnabled
parameter being set tofalse
ortrue
respectiveyUpwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @allroundexpertsThe text was updated successfully, but these errors were encountered: