[$500] IOU - Distance request with vague location created offline shows incorrect error online

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.41
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4314136
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch app
2. Turn off mobile data
3. Tap fab
4. Tap request money--- distance
5. Tap start
6. Enter SF and tap save
7. Tap finish
8. Enter LA and tap save
9. Tap next
10. Select a workspace
11. Tap request
12. Turn on mobile data

Expected Result:

In offline, with vague location distance request created after turning online must show correct error message "Unable to find the location for this address. Please edit the address and try again. ”

Actual Result:

In offline, with vague location distance request created after turning online shows incorrect error message "Unexpected error requesting money, please try again later" instead of "Unable to find the location for this address. Please edit the address and try again.”

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6379221_1707909726182.tes.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014b08208fbad4a9ac
• Upwork Job ID: 1757776229611659264
• Last Price Increase: 2024-02-21

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014b08208fbad4a9ac

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

We think that this bug might be related to #wave5
CC @dylanexpensify

[jliexpensify]

Asked Dylan here - https://expensify.slack.com/archives/C05DWUDHVK7/p1707961175788869

[brunovjk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect error message displayed in app for offline-created distance request when online.

What is the root cause of that problem?

In buildOnyxDataForMoneyRequest we always use a genericCreateFailureMessage for transaction failure:

App/src/libs/actions/IOU.ts

Line 612 in 935c44a

errors: ErrorUtils.getMicroSecondOnyxError('iou.error.genericCreateFailureMessage'),

App/src/languages/en.ts

Line 654 in 935c44a

genericCreateFailureMessage: 'Unexpected error requesting money, please try again later',

What changes do you think we should make in order to solve the problem?

We need to add a "Unable to find the location for this address. Please edit the address and try again." at anguages/en.ts, sometjhing like:

error: {
    // ... (existing error messages)
    invalidLocation: 'Unable to find the location for this address. Please edit the address and try again.',
    // ... (other error messages)
}

And properly use it when the request fails due to invalid waypoints.

What alternative solutions did you explore? (Optional)

[c3024]

@brunovjk

Could you be more specific about which conditions (with variables) will wel add this invalidLocation error. Also, isn't this error sent by the backend?

[brunovjk]

@c3024 yes I can, but before can you answer me one thing? With the same steps for reproduction this issue has a different Expected Result. Are we dealing with a kind of new feature here? Thank you.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[jliexpensify]

Bump @c3024

[brunovjk]

I've been investigating and couldn't find a solution completely through the frontend. In addition to the new message "Unable to find the location for this address. Please edit the address and try again.", I believe there is a problem with the backend here, the issue report video doesn't show it but the request appears to be deleted without even the user "dismissing the error".

[jliexpensify]

Bump @c3024 - can you confirm if this is a back-end issue? Thanks!

[jliexpensify]

Actually should be #wave6 - posted: https://expensify.slack.com/archives/C02MW39LT9N/p1708900139785349

[brunovjk]

@jliexpensify external like me do not have access to this archive right?

[jliexpensify]

@brunovjk - if it's a back-end issue, we'll apply the Internal label for an Expensify Engineer to pick up.

From that point on, the engineer can determine if we need help from Contributors.

[c3024]

@jliexpensify

Yes, the validation happens on backend so backend sending the correct error message is appropriate. Please apply Internal label. Thanks.

[melvin-bot]

Current assignee @c3024 is eligible for the Internal assigner, not assigning anyone new.

[neil-marcellini]

This is basically due to the fact that we don't handle offline distance request errors very well. We have an issue to fix that here, [LOW] Distance: Handle errors with geocoding for offline distance requests, but no one has picked it up. I think we should close this in favor of that one, or at least HOLD on it @jliexpensify

[jliexpensify]

Great, thanks for jumping in Neil. Closing (also requested by Greg)!