Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wave 6: Drafts] Report submission is not reflecting real time for admin #32642

Closed
mountiny opened this issue Dec 7, 2023 · 11 comments
Closed
Assignees
Labels
Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@mountiny
Copy link
Contributor

mountiny commented Dec 7, 2023

Problem

When draft report is submitted by the employee, the admin view does not reflect that in the UI.

Screen.Recording.2023-12-07.at.11.39.45.mp4

Solution

Ensure all the necessary updates are sent from the API when report is submitted.

That would be update to the expense report with its state and status changing as well as update report preview action

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018ab22e1ebff399ab
  • Upwork Job ID: 1734571062109163520
  • Last Price Increase: 2023-12-12
@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels Dec 7, 2023
Copy link

melvin-bot bot commented Dec 7, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Dec 7, 2023
@CortneyOfstad
Copy link
Contributor

CortneyOfstad commented Dec 11, 2023

@mountiny would we consider this an internal or external issue? Just making sure I am applying the correct labels 👍

@mountiny
Copy link
Contributor Author

This needs to be internal and i believe @marcochavezf might have a fix ip for this, maybe

@CortneyOfstad CortneyOfstad added the Internal Requires API changes or must be handled by Expensify staff label Dec 12, 2023
Copy link

melvin-bot bot commented Dec 12, 2023

Job added to Upwork: https://www.upwork.com/jobs/~018ab22e1ebff399ab

Copy link

melvin-bot bot commented Dec 12, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

@marcochavezf marcochavezf added Daily KSv2 and removed Weekly KSv2 labels Dec 13, 2023
@marcochavezf
Copy link
Contributor

I noticed that in the last PR, we only send the updated expense report data to the approver (manager) and not to other admins in the workspace, so I created this PR to also send the updated data to all admins in the workspace chat.

@marcochavezf marcochavezf added the Reviewing Has a PR in review label Dec 15, 2023
@greg-schroeder greg-schroeder changed the title [Drafts] Report submission is not reflecting real time for admin [Wave 6: Drafts] Report submission is not reflecting real time for admin Dec 18, 2023
Copy link

melvin-bot bot commented Dec 22, 2023

@marcochavezf, @CortneyOfstad, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

@CortneyOfstad
Copy link
Contributor

Any updates on this? TIA!

Copy link

melvin-bot bot commented Jan 1, 2024

@marcochavezf, @CortneyOfstad, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Jan 2, 2024

@marcochavezf, @CortneyOfstad, @rushatgabhane Still overdue 6 days?! Let's take care of this!

@marcochavezf
Copy link
Contributor

The PR was already deployed to production two weeks ago. I will close this GH issue manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
No open projects
Development

No branches or pull requests

4 participants