From f6828ab5c83a59082c9fc658540265c8dba54244 Mon Sep 17 00:00:00 2001
From: cdOut <88325488+cdOut@users.noreply.github.com>
Date: Thu, 14 Dec 2023 00:58:41 +0100
Subject: [PATCH] add review nitpicks and changes

---
 .../GrowlNotificationContainer/index.tsx                  | 8 ++++----
 src/components/GrowlNotification/index.tsx                | 3 ++-
 src/components/GrowlNotification/types.ts                 | 7 ++++++-
 3 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/src/components/GrowlNotification/GrowlNotificationContainer/index.tsx b/src/components/GrowlNotification/GrowlNotificationContainer/index.tsx
index 9f65e269ee96..07530c117f60 100644
--- a/src/components/GrowlNotification/GrowlNotificationContainer/index.tsx
+++ b/src/components/GrowlNotification/GrowlNotificationContainer/index.tsx
@@ -1,12 +1,12 @@
 import React from 'react';
 import {Animated} from 'react-native';
-import withWindowDimensions from '@components/withWindowDimensions';
-import {WindowDimensionsProps} from '@components/withWindowDimensions/types';
+import useWindowDimensions from '@hooks/useWindowDimensions';
 import useThemeStyles from '@styles/useThemeStyles';
 import GrowlNotificationContainerProps from './types';
 
-function GrowlNotificationContainer({children, translateY, isSmallScreenWidth}: GrowlNotificationContainerProps & WindowDimensionsProps) {
+function GrowlNotificationContainer({children, translateY}: GrowlNotificationContainerProps) {
     const styles = useThemeStyles();
+    const {isSmallScreenWidth} = useWindowDimensions();
 
     return (
         <Animated.View
@@ -19,4 +19,4 @@ function GrowlNotificationContainer({children, translateY, isSmallScreenWidth}:
 
 GrowlNotificationContainer.displayName = 'GrowlNotificationContainer';
 
-export default withWindowDimensions(GrowlNotificationContainer);
+export default GrowlNotificationContainer;
diff --git a/src/components/GrowlNotification/index.tsx b/src/components/GrowlNotification/index.tsx
index 84a56594943e..a5ffa848fecb 100644
--- a/src/components/GrowlNotification/index.tsx
+++ b/src/components/GrowlNotification/index.tsx
@@ -18,7 +18,8 @@ const INACTIVE_POSITION_Y = -255;
 
 const PressableWithoutFeedback = Pressables.PressableWithoutFeedback;
 
-function GrowlNotification({ref}: GrowlNotificationProps) {
+// eslint-disable-next-line @typescript-eslint/naming-convention, @typescript-eslint/no-unused-vars
+function GrowlNotification({_, ref}: GrowlNotificationProps) {
     const translateY = useRef(new Animated.Value(INACTIVE_POSITION_Y)).current;
     const [bodyText, setBodyText] = useState('');
     const [type, setType] = useState('success');
diff --git a/src/components/GrowlNotification/types.ts b/src/components/GrowlNotification/types.ts
index edee6ce6b37a..a984008978ed 100644
--- a/src/components/GrowlNotification/types.ts
+++ b/src/components/GrowlNotification/types.ts
@@ -1,9 +1,14 @@
+import {ForwardedRef} from 'react';
+
 type GrowlRef = {
     show?: (bodyText: string, type: string, duration: number) => void;
 };
 
 type GrowlNotificationProps = {
-    ref: React.RefObject<GrowlRef>;
+    // eslint-disable-next-line @typescript-eslint/naming-convention
+    _: unknown;
+
+    ref: ForwardedRef<GrowlRef>;
 };
 
 export type {GrowlRef, GrowlNotificationProps};