From f7b308d2b7253cdd913afa5c30ea517a1fcdb389 Mon Sep 17 00:00:00 2001 From: nkdengineer Date: Wed, 5 Feb 2025 14:06:49 +0700 Subject: [PATCH 1/2] fix: App is stuck on the confirmation page when submitting expense --- src/libs/actions/IOU.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/actions/IOU.ts b/src/libs/actions/IOU.ts index 654f9a33928c..9ce720b55c26 100644 --- a/src/libs/actions/IOU.ts +++ b/src/libs/actions/IOU.ts @@ -4427,7 +4427,7 @@ function requestMoney(requestMoneyInformation: RequestMoneyInformation) { switch (action) { case CONST.IOU.ACTION.SUBMIT: { - if (!linkedTrackedExpenseReportAction || !actionableWhisperReportActionID || !linkedTrackedExpenseReportID) { + if (!linkedTrackedExpenseReportAction || !linkedTrackedExpenseReportID) { return; } const workspaceParams = From 46d19203921b090805178c6dbee6b65675002d1a Mon Sep 17 00:00:00 2001 From: nkdengineer Date: Wed, 5 Feb 2025 14:16:33 +0700 Subject: [PATCH 2/2] fix ts --- src/libs/API/parameters/AddTrackedExpenseToPolicyParams.ts | 2 +- .../API/parameters/ConvertTrackedExpenseToRequestParams.ts | 2 +- src/libs/actions/IOU.ts | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libs/API/parameters/AddTrackedExpenseToPolicyParams.ts b/src/libs/API/parameters/AddTrackedExpenseToPolicyParams.ts index 3c2441b205e4..02fdce59a173 100644 --- a/src/libs/API/parameters/AddTrackedExpenseToPolicyParams.ts +++ b/src/libs/API/parameters/AddTrackedExpenseToPolicyParams.ts @@ -17,7 +17,7 @@ type AddTrackedExpenseToPolicyParams = { customUnitRateID?: string; policyID: string; transactionID: string; - actionableWhisperReportActionID: string; + actionableWhisperReportActionID: string | undefined; moneyRequestReportID: string; reportPreviewReportActionID: string; modifiedExpenseReportActionID: string; diff --git a/src/libs/API/parameters/ConvertTrackedExpenseToRequestParams.ts b/src/libs/API/parameters/ConvertTrackedExpenseToRequestParams.ts index 21a59f7e614f..e0fad14b4fec 100644 --- a/src/libs/API/parameters/ConvertTrackedExpenseToRequestParams.ts +++ b/src/libs/API/parameters/ConvertTrackedExpenseToRequestParams.ts @@ -7,7 +7,7 @@ type ConvertTrackedExpenseToRequestParams = { payerAccountID: number; chatReportID: string; transactionID: string; - actionableWhisperReportActionID: string; + actionableWhisperReportActionID: string | undefined; createdChatReportActionID?: string; moneyRequestReportID: string; moneyRequestCreatedReportActionID: string | undefined; diff --git a/src/libs/actions/IOU.ts b/src/libs/actions/IOU.ts index 9ce720b55c26..d2b4d018bc23 100644 --- a/src/libs/actions/IOU.ts +++ b/src/libs/actions/IOU.ts @@ -4157,7 +4157,7 @@ type AddTrackedExpenseToPolicyParam = { merchant: string; transactionID: string; reimbursable: boolean; - actionableWhisperReportActionID: string; + actionableWhisperReportActionID: string | undefined; moneyRequestReportID: string; reportPreviewReportActionID: string; modifiedExpenseReportActionID: string; @@ -4174,7 +4174,7 @@ function convertTrackedExpenseToRequest( payerEmail: string, chatReportID: string, transactionID: string, - actionableWhisperReportActionID: string, + actionableWhisperReportActionID: string | undefined, createdChatReportActionID: string | undefined, moneyRequestReportID: string, moneyRequestCreatedReportActionID: string | undefined,