-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preciser Status on each Website (Inactive/active) #49
Comments
I think items 1. 2. and 3. would be appreciated! I think stuff like adding the number of completions accepted we might want our own design team to first make a spec. |
Thanks @fortenforge @pqn But I'm blocked by how to disable the functionality of Codeium completion after injection (as the page is already loaded). Two approaches:
What do you think about it? Do you need me to create a draft PR with current progress and have a discussion? By the way, I found Colab supports their built-in completion now. It might not be a good way to overwrite the Monaco completion for it. |
Can we write the same code twice, once in each implementations (CodeMirror and Monaco), to be able to read some state change caused by the context menu? Then if Codeium is disabled behave as a noop.
If this is true for everyone then we can disable it. |
Not for every user, but only some eligible ones: https://blog.google/technology/developers/google-colab-ai-coding-features/ I'm just wondering how to handle this. |
For Colab let's leave it on for now in that case. Not sure how Monaco will choose between them but as long as the user gets some completions it's probably okay either way. |
Hi @pqn @fortenforge, Thanks for your help. I tried to implement 1 and 3 in this draft #51 I'm not certain whether I understand your idea correctly so I created that PR early for tests and discussion. The code is dirty now, I will clean it up further if needed. Please let me know if I misunderstand anything. And also, should I also push the implementation of 3 in the same PR, or is it more comfortable to review and handle the code so far? Either is fine to me. |
Thanks! I think it's fine to keep 3 in the same PR, it's not unmanageably sized right now. |
Currently, the popup page and extension icon seem too primitive (another related complaint: #48). I feel a little painful when
My desired feature looks like wakatime, which also tracks the activities of the user and includes white/black list feature.
I'd like to work on this enhancement by this weekend, make the popup page more fancy as well (such as showing how many completions are accepted today, or the graph). Please let me know if the idea is acceptable or conflict with others.
The text was updated successfully, but these errors were encountered: