fix: group(rank) and renaming of some properties (#676)

* Bug fixes and renaming of some properties to more understandable ones. We need to test this to make sure it doesn't cause problems, because God only knows how it all works internally.
https://discord.com/channels/656673194693885975/1002713309876854924/1432873468285948055

* Revert "Bug fixes and renaming of some properties to more understandable ones. We need to test this to make sure it doesn't cause problems, because God only knows how it all works internally."

This reverts commit c72eabf.

* Fix a fix

* Update EXILED/Exiled.API/Features/Player.cs

* Fix RemoteAdminPermissions property

---------

Co-authored-by: PUDGE <PUDGE@PUDGE>
Co-authored-by: Yamato <[email protected]>

Author: 3 people

EXILED/Exiled.API/Features/Player.cs

@@ -564,7 +564,11 @@ public Quaternion Rotation
         public PlayerPermissions RemoteAdminPermissions
         {
             get => (PlayerPermissions)ReferenceHub.serverRoles.Permissions;
-            set => ReferenceHub.serverRoles.Permissions = (ulong)value;
+            set
+            {
+                ReferenceHub.serverRoles.Permissions = (ulong)value;
+                ReferenceHub.serverRoles.FinalizeSetGroup();
+            }
         }
 
         /// <summary>
@@ -1915,25 +1919,19 @@ public bool TryGetItem(ushort serial, out Item item)
         }
 
         /// <summary>
-        /// Sets the player's rank.
+        /// Receives an existing rank(group) or, if it doesn't exist, creates a new one and assigns it to this player.
         /// </summary>
         /// <param name="name">The rank name to be set.</param>
         /// <param name="group">The group to be set.</param>
         public void SetRank(string name, UserGroup group)
         {
             if (ServerStatic.PermissionsHandler.Groups.TryGetValue(name, out UserGroup userGroup))
             {
-                userGroup.BadgeColor = group.BadgeColor;
-                userGroup.BadgeText = name;
-                userGroup.HiddenByDefault = !group.Cover;
-                userGroup.Cover = group.Cover;
-
                 ReferenceHub.serverRoles.SetGroup(userGroup, false, false);
             }
             else
             {
                 ServerStatic.PermissionsHandler.Groups.Add(name, group);
-
                 ReferenceHub.serverRoles.SetGroup(group, false, false);
             }