Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2025-0009: Some AES functions may panic when overflow checking is enabled. #2730

Open
github-actions bot opened this issue Mar 7, 2025 · 1 comment

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Some AES functions may panic when overflow checking is enabled.

Details
Package ring
Version 0.16.20
URL https://github.com/briansmith/ring/blob/main/RELEASES.md#version-01712-2025-03-05
Date 2025-03-06
Patched versions >=0.17.12

ring::aead::quic::HeaderProtectionKey::new_mask() may panic when overflow
checking is enabled. In the QUIC protocol, an attacker can induce this panic by
sending a specially-crafted packet. Even unintentionally it is likely to occur
in 1 out of every 2**32 packets sent and/or received.

On 64-bit targets operations using ring::aead::{AES_128_GCM, AES_256_GCM} may
panic when overflow checking is enabled, when encrypting/decrypting approximately
68,719,476,700 bytes (about 64 gigabytes) of data in a single chunk. Protocols
like TLS and SSH are not affected by this because those protocols break large
amounts of data into small chunks. Similarly, most applications will not
attempt to encrypt/decrypt 64GB of data in one chunk.

Overflow checking is not enabled in release mode by default, but
RUSTFLAGS="-C overflow-checks" or overflow-checks = true in the Cargo.toml
profile can override this. Overflow checking is usually enabled by default in
debug mode.

See advisory page for additional details.

@sveitser
Copy link
Collaborator

sveitser commented Mar 7, 2025

I think we can't upgrade this easily because we have a tertiary dependency on 0.16 via ethers that is unmaintained and hard to remove from our codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant