-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors in tests #131
Comments
Hmm, that seems like a pytest issue rather than an issue with xdoctest. (FWIW I'm really not a fan of the testdir fixture, I use it only to verify backwards compatibility with the pytest doctest tests). It's far too magic for my taste. Do the doctests themselves pass? I.e. running I'm also wondering how you are running the tests? Also the version of pytest would be good to know. If you have the bandwidth, a dockerfile that setups a MWE that illustrates the issue on FreeBSD would be the most valuable. |
|
That's an OK failure. It's a problem with the test, not the library. Still needs to be fixed though. I made the naive assumption that win32, linux, and darwin were the only values of The pytest failure is strange though. Versions of pytest and how the tests are being invoked would be good to know here. |
Yes, 'freebsd' should be added there. |
|
Complete pytest invokation:
|
Do you know if it is picking up the pytest.ini or pyproject.toml settings in the base of the repo? It includes extra addopts that are probably needed here:
|
The non-pytest issue is fixed in 6af2790 Still not sure what's happening with pytest. I don't have a freebsd machine to test on. Apparently docker doesn't support it. Based on: pytest-dev/pytest#9284 and pytest-dev/pytest#9280 I would recommend trying to add |
1.0.2 has these failures:
|
Did you try adding |
I installed a FreeBSD VM and was able to reproduce your errors. There were two errors that need to be fixed in xdoctest itself. Those fixes are on: #134 However, the "testdir" errors are due to the way you are invoking pytest. When I run: I got 83 errors: But if I add the option that tells pytest to use the pytester option: I get no errors and 196 tests pass: However, you might notice that these tests do not include any of the doctests themselves! That is because you aren't using the pytest configuration specified in
Results in 288 tests passed. |
With the above command (python -m pytest -k '' -p pytester -rs -v -o addopts=) 5 tests fail in version 1.1.1:
The 'testdir' error is gone. |
Version: 1.0.1
FreeBSD 13.1
The text was updated successfully, but these errors were encountered: