Actually implement the feature

Author: EpocDotFr

README.md

@@ -23,7 +23,9 @@ A browser extension that enhance all Merge Requests lists on any instance of Git
     - Base Jira URL is configured in extension preferences
     - The ticket ID or an icon can be displayed as the link label (configured in extension preferences)
   - WIP toggle button (can be enabled/disabled in the extension preferences)
-  - Show an indicator when there's unresolved discussions left on Merge Requests (can be enabled/disabled in the extension preferences)
+  - Show an indicator when there's unresolved discussions left on Merge Requests
+    - Can be enabled/disabled in the extension preferences
+    - Note the **All discussions must be resolved** option must be enabled for this feature to be working as expected. This option must be enabled per project and is located in **Settings > General > Merge Requests > Merge checks**
   - Compatible with all GitLab editions (GitLab CE, GitLab EE, GitLab.com) (look at the prerequisites, though)
 
 ## Prerequisites

html/options.html

@@ -67,7 +67,7 @@
                 <input type="checkbox" id="enable_unresolved_discussions_indicator">
             </div>
             <div class="fluid">
-                <label for="enable_unresolved_discussions_indicator">Show an indicator when there's unresolved discussions left</label>
+                <label for="enable_unresolved_discussions_indicator">Show an indicator when there's unresolved discussion(s) left</label>
             </div>
         </div>
         <div class="txt-center pts pbs"><button type="submit" class="browser-style">Save preferences</button></div>

js/content.js

@@ -416,6 +416,18 @@
                         newInfoLineToInject
                     );
                 }
+
+                // -----------------------------------------------
+                // Unresolved discussions indicator
+
+                if (this.preferences.enable_unresolved_discussions_indicator && !mergeRequest.blocking_discussions_resolved) {
+                    let unresolvedDiscussionsIndicatorToInject = '<li><span class="has-tooltip" title="Unresolved discussion(s) left">' + this.buildSpriteIcon('comment-dots', 'danger-title') + '</span></li>';
+
+                    this.parseHtmlAndPrepend(
+                        mergeRequestNode.querySelector('.issuable-meta .controls'),
+                        unresolvedDiscussionsIndicatorToInject
+                    );
+                }
             }, this);
         }
 
@@ -597,8 +609,8 @@
         /**
          * Generate the HTML code corresponding to an SVG icon.
          */
-        buildSpriteIcon(iconName) {
-            return '<svg class="s16" data-testid="' + iconName + '-icon">' +
+        buildSpriteIcon(iconName, classes = '') {
+            return '<svg class="s16 ' + classes + '" data-testid="' + iconName + '-icon">' +
                 '<use xlink:href="' + this.baseIconsUrl + '#' + iconName + '"></use>' +
             '</svg>';
         }