Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

Commit 5341b9e

Browse files
committed
Add the new option
1 parent 75be40a commit 5341b9e

File tree

3 files changed

+23
-3
lines changed

3 files changed

+23
-3
lines changed

html/options.html

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,14 @@
6262
<div class="pbs pll">
6363
<small class="txt-muted">This feature is automatically disabled if logged-out</small>
6464
</div>
65+
<div class="pts row">
66+
<div class="w40p txt-center browser-style">
67+
<input type="checkbox" id="enable_unresolved_discussions_indicator">
68+
</div>
69+
<div class="fluid">
70+
<label for="enable_unresolved_discussions_indicator">Show an indicator when there's unresolved discussions left</label>
71+
</div>
72+
</div>
6573
<div class="txt-center pts pbs"><button type="submit" class="browser-style">Save preferences</button></div>
6674
</form>
6775

js/options.js

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@
3737
this.jiraTicketLinkLabelTypeRadioButtons = Array.from(document.querySelectorAll('input[name="jira_ticket_link_label_type"]'));
3838

3939
this.enableButtonToToggleWipStatusCheckbox = document.querySelector('input#enable_button_to_toggle_wip_status');
40+
41+
this.enableUnresolvedDiscussionsIndicatorCheckbox = document.querySelector('input#enable_unresolved_discussions_indicator');
4042
}
4143

4244
/**
@@ -67,6 +69,9 @@
6769

6870
self.enableButtonToToggleWipStatusCheckbox.checked = preferences.enable_button_to_toggle_wip_status;
6971
self.enableButtonToToggleWipStatusCheckbox.dispatchEvent(new CustomEvent('change'));
72+
73+
self.enableUnresolvedDiscussionsIndicatorCheckbox.checked = preferences.enable_unresolved_discussions_indicator;
74+
self.enableUnresolvedDiscussionsIndicatorCheckbox.dispatchEvent(new CustomEvent('change'));
7075
});
7176
}
7277

@@ -117,6 +122,10 @@
117122
this.enableButtonToToggleWipStatusCheckbox.addEventListener('change', function() {
118123
self.forceUserToEnableAtLeastOneFeatureIfNecessarily();
119124
});
125+
126+
this.enableUnresolvedDiscussionsIndicatorCheckbox.addEventListener('change', function() {
127+
self.forceUserToEnableAtLeastOneFeatureIfNecessarily();
128+
});
120129
}
121130

122131
/**
@@ -138,7 +147,8 @@
138147
enable_jira_ticket_link: this.enableJiraTicketLinkCheckbox.checked,
139148
base_jira_url: this.baseJiraUrlInput.value,
140149
jira_ticket_link_label_type: jira_ticket_link_label_type,
141-
enable_button_to_toggle_wip_status: this.enableButtonToToggleWipStatusCheckbox.checked
150+
enable_button_to_toggle_wip_status: this.enableButtonToToggleWipStatusCheckbox.checked,
151+
enable_unresolved_discussions_indicator: this.enableUnresolvedDiscussionsIndicatorCheckbox.checked
142152
},
143153
function() {
144154
self.setSuccessfulVisualFeedbackOnSubmitButton();
@@ -173,7 +183,8 @@
173183
return !this.displaySourceAndTargetBranchesCheckbox.checked
174184
&& !this.enableButtonToCopyMrInfoCheckbox.checked
175185
&& !this.enableJiraTicketLinkCheckbox.checked
176-
&& !this.enableButtonToToggleWipStatusCheckbox.checked;
186+
&& !this.enableButtonToToggleWipStatusCheckbox.checked
187+
&& !this.enableUnresolvedDiscussionsIndicatorCheckbox.checked;
177188
}
178189

179190
/**

js/preferences.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@
1313
enable_jira_ticket_link: false,
1414
base_jira_url: '',
1515
jira_ticket_link_label_type: 'ticket_id',
16-
enable_button_to_toggle_wip_status: true
16+
enable_button_to_toggle_wip_status: true,
17+
enable_unresolved_discussions_indicator: true
1718
};
1819
}
1920

0 commit comments

Comments
 (0)