Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit print module #159

Open
2 of 7 tasks
kdmnk opened this issue Oct 12, 2022 · 2 comments
Open
2 of 7 tasks

Revisit print module #159

kdmnk opened this issue Oct 12, 2022 · 2 comments
Assignees
@sszajbely
Labels
bug Something isn't working refactor/rebase Changing the structure of the code or modifying representations
Milestone
Release 4.0.

Comments

@kdmnk
Copy link
Contributor

kdmnk commented Oct 12, 2022 •
edited
Loading

Make sure everything is working as expected and refactor if needed.

Including:
@kdmnk kdmnk added the refactor/rebase Changing the structure of the code or modifying representations label Oct 12, 2022
@kdmnk kdmnk added this to the Release 4.0. milestone Oct 12, 2022
@kdmnk kdmnk mentioned this issue Jun 16, 2023
Closed
@kdmnk kdmnk added the bug Something isn't working label Jun 16, 2023
@viktorcsimma
Copy link
Contributor

@kdmnk I've checked it; for me the only issue was that it incorrectly allowed printing with free pages even when I didn't have enough (then it set the appropriate item to 0). But otherwise, it subtracted them correctly.

@kdmnk
Copy link
Contributor Author

kdmnk commented Jun 16, 2023

@viktorcsimma Thanks. Could you reproduce #51?

@kdmnk kdmnk mentioned this issue Dec 11, 2023
Open
@kdmnk kdmnk mentioned this issue Dec 18, 2023
Closed
3 tasks
@coderabbitai coderabbitai bot mentioned this issue Dec 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sszajbely sszajbely

Labels
bug Something isn't working refactor/rebase Changing the structure of the code or modifying representations
Projects
None yet
Milestone
Release 4.0.
Development

No branches or pull requests
3 participants
@sszajbely @kdmnk @viktorcsimma